[PATCH 12/13] tests/intel/xe_oa: Fix mmio_trigger_reports testing

Dixit, Ashutosh ashutosh.dixit at intel.com
Sat Feb 22 03:32:05 UTC 2025


On Fri, 14 Feb 2025 17:06:27 -0800, Umesh Nerlige Ramappa wrote:
>
> The MI_STORE command needs modification to set the right amount of dwords. While
> at it, set the default exponent and add a render_copy check.

What is the second sentence here referring to, please fix:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
> ---
>  tests/intel/xe_oa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index ff1b873d5..d44832a8a 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -3688,7 +3688,7 @@ emit_oa_reg_read(struct intel_bb *ibb, struct intel_buf *dst, uint32_t offset,
>  {
>	intel_bb_add_intel_buf(ibb, dst, true);
>
> -	intel_bb_out(ibb, MI_STORE_REGISTER_MEM | 2);
> +	intel_bb_out(ibb, MI_STORE_REGISTER_MEM_GEN8);
>	intel_bb_out(ibb, reg);
>	intel_bb_emit_reloc(ibb, dst->handle,
>			    I915_GEM_DOMAIN_INSTRUCTION,
> --
> 2.34.1
>


More information about the igt-dev mailing list