[PATCH i-g-t v6] tests/kms_histogram: Added IGT support to validate global histogram

Lucas De Marchi lucas.demarchi at intel.com
Sat Jan 4 06:26:27 UTC 2025


On Thu, Dec 12, 2024 at 02:01:19AM +0530, Mohammed Thasleem wrote:
>+static struct globalhist_args *algo_get_pixel_factor(drmModePropertyBlobRes *global_hist_blob,
>+						    igt_output_t *output)
>+{
>+	struct globalhist_args *argsPtr =
>+		(struct globalhist_args *)malloc(sizeof(struct globalhist_args));
>+
>+	drmModeModeInfo *mode;
>+
>+	mode = igt_output_get_mode(output);
>+
>+	memcpy(argsPtr->histogram, global_hist_blob->data, global_hist_blob->length);
>+	argsPtr->resolution_x = mode->hdisplay;
>+	argsPtr->resolution_y = mode->vdisplay;
>+
>+	igt_debug("Making call to global histogram algorithm.\n");
>+	histogram_compute_generate_data_bin(argsPtr);

../tests/kms_histogram.c: In function ‘algo_get_pixel_factor’:
../tests/kms_histogram.c:166:9: error: implicit declaration of function ‘histogram_compute_generate_data_bin’ [-Wimplicit-function-declaration]
   166 |         histogram_compute_generate_data_bin(argsPtr);
       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../tests/kms_histogram.c:166:9: warning: nested extern declaration of ‘histogram_compute_generate_data_bin’ [-Wnested-externs]

Looking at ghe.h in Ubuntu 24.10, it seems this function doesn't exist.
I thought the dep was missing a version check, but checking https://github.com/intel/ghe
it seems it never existed. What am I missing?


Lucas De Marchi


More information about the igt-dev mailing list