[PATCH i-g-t 2/8] lib/xe/xe_gt: Fix header guards and boilerplate

Cavitt, Jonathan jonathan.cavitt at intel.com
Mon Jan 6 22:58:10 UTC 2025


-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Lucas De Marchi
Sent: Friday, January 3, 2025 11:16 PM
To: igt-dev at lists.freedesktop.org
Cc: De Marchi, Lucas <lucas.demarchi at intel.com>
Subject: [PATCH i-g-t 2/8] lib/xe/xe_gt: Fix header guards and boilerplate
> 
> Add proper header guard and remove author from comment: authorship is
> maintained in git, not as comment.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  lib/xe/xe_gt.c | 3 ---
>  lib/xe/xe_gt.h | 8 +++++---
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/xe/xe_gt.c b/lib/xe/xe_gt.c
> index 1f4b42ed9..53554beb0 100644
> --- a/lib/xe/xe_gt.c
> +++ b/lib/xe/xe_gt.c
> @@ -1,9 +1,6 @@
>  /* SPDX-License-Identifier: MIT */
>  /*
>   * Copyright (c) 2023 Intel Corporation
> - *
> - * Authors:
> - *    Janga Rahul Kumar <janga.rahul.kumar at intel.com>
>   */
>  
>  #include <fcntl.h>
> diff --git a/lib/xe/xe_gt.h b/lib/xe/xe_gt.h
> index a4bb85679..756b5f38e 100644
> --- a/lib/xe/xe_gt.h
> +++ b/lib/xe/xe_gt.h
> @@ -1,11 +1,11 @@
>  /* SPDX-License-Identifier: MIT */
>  /*
>   * Copyright (c) 2023 Intel Corporation
> - *
> - * Authors:
> - *    Janga Rahul Kumar <janga.rahul.kumar at intel.com>
>   */
>  
> +#ifndef XE_GT_H
> +#define XE_GT_H
> +
>  #include "lib/igt_gt.h"
>  
>  bool has_xe_gt_reset(int fd);
> @@ -14,3 +14,5 @@ igt_hang_t xe_hang_ring(int fd, uint64_t ahnd, uint32_t ctx, int ring,
>  				unsigned int flags);
>  void xe_post_hang_ring(int fd, igt_hang_t arg);
>  int xe_gt_stats_get_count(int fd, int gt, const char *stat);
> +
> +#endif
> -- 
> 2.47.0
> 
> 


More information about the igt-dev mailing list