[PATCH i-g-t] tests/kms_histogram: Add check for ghe api call

[Garg, Nemesa]

I have updated the ghe lib and changes are merged.

> -----Original Message-----
> From: Thasleem, Mohammed <mohammed.thasleem at intel.com>
> Sent: Tuesday, January 7, 2025 1:24 PM
> To: De Marchi, Lucas <lucas.demarchi at intel.com>; Garg, Nemesa
> <nemesa.garg at intel.com>; Murthy, Arun R <arun.r.murthy at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Kamil Konieczny
> <kamil.konieczny at linux.intel.com>; Kurmi, Suresh Kumar
> <suresh.kumar.kurmi at intel.com>; Lattannavar, Sameer
> <sameer.lattannavar at intel.com>
> Subject: RE: [PATCH i-g-t] tests/kms_histogram: Add check for ghe api call
> 
> @De Marchi, Lucas, As per the internal discussion we have updated the api
> name in IGT and accordingly we have merged.
> 
> @Garg, Nemesa , What is ETA to do the same changes in GHE lib?
> 
> FYI @Murthy, Arun R
> 
> 
> -----Original Message-----
> From: De Marchi, Lucas <lucas.demarchi at intel.com>
> Sent: Monday, January 6, 2025 10:43 PM
> To: Thasleem, Mohammed <mohammed.thasleem at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Murthy, Arun R
> <arun.r.murthy at intel.com>; Garg, Nemesa <nemesa.garg at intel.com>; Kamil
> Konieczny <kamil.konieczny at linux.intel.com>
> Subject: Re: [PATCH i-g-t] tests/kms_histogram: Add check for ghe api call
> 
> On Mon, Jan 06, 2025 at 03:21:54PM +0530, Mohammed Thasleem wrote:
> >Check ghe algo for the function called by ghe igt while compiling.
> >
> >Signed-off-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
> >---
> > meson.build | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> >diff --git a/meson.build b/meson.build
> >index 8b2a2a64a..96f010fe2 100644
> >--- a/meson.build
> >+++ b/meson.build
> >@@ -198,8 +198,19 @@ else
> > endif
> >
> > libghe = dependency('libghe', required : false)
> >+
> > if libghe.found()
> >-      config.set('HAVE_LIBGHE', 1)
> >+
> >+	cc = meson.get_compiler('c')
> >+
> >+	if cc.has_function('histogram_compute_generate_data_bin',
> dependencies: libghe)
> >+		message('libghe provides the required function')
> >+		config.set('HAVE_LIBGHE', 1)
> >+	else
> >+	warning('libghe does not provide the required function')
> >+	endif
> 
> what's the a proper libghe that provide
> histogram_compute_generate_data_bin()
> and how were things tested? If there is libghe available, build is just broken.
> 
> Ideally we'd have something like is done for other libraries.
> 
> 	libghe = dependency('libghe', version : '>=0.2', required : false)
> 
> However, looking at https://github.com/intel/ghe, there's no such function,
> which leads me to think this call is actually a typo to something else like
> set_histogram_data_bin()?
> 
> Cc: Arun R Murthy <arun.r.murthy at intel.com>
> Cc: Nemesa Garg <nemesa.garg at intel.com>
> 
> >+else
> >+	warning('libghe not found')
> 
> no warning should be added here, like it's not added for the multiple other
> libraries.
> 
> Lucas De Marchi
> 
> > endif
> >
> > build_info += 'Build Chamelium test: @0@'.format(chamelium.found())
> >--
> >2.25.1
> >