[PATCH i-g-t 5/5] tests/xe_sriov_auto_provisioning: Add tests for SR-IOV auto-provisioning
Laguna, Lukasz
lukasz.laguna at intel.com
Tue Jan 7 11:52:06 UTC 2025
On 12/19/2024 16:54, Bernatowicz, Marcin wrote:
>
>
> On 12/19/2024 3:48 PM, Laguna, Lukasz wrote:
>> On 12/18/2024 13:00, Marcin Bernatowicz wrote:
>>> Added subtests validating below scenarios:
>>> - auto-provisioned resources are allocated by PF driver in fairly
>>> manner,
>>> - auto-provisioned resources are released once VFs are disabled,
>>> - verify that ranges of auto-provisioned resources are exclusive.
>>>
>>> The tests rely on ggtt_provisioned, lmem_provisioned,
>>> contexts_provisioned and doorbells_provisioned debugfs attributes.
>>>
>>> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
>>> Cc: Adam Miszczak <adam.miszczak at linux.intel.com>
>>> Cc: Jakub Kolakowski <jakub1.kolakowski at intel.com>
>>> Cc: Lukasz Laguna <lukasz.laguna at intel.com>
>>> Cc: Michał Wajdeczko <michal.wajdeczko at intel.com>
>>> Cc: Michał Winiarski <michal.winiarski at intel.com>
>>> Cc: Narasimha C V <narasimha.c.v at intel.com>
>>> Cc: Piotr Piórkowski <piotr.piorkowski at intel.com>
>>> Cc: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
>>> Cc: Tomasz Lis <tomasz.lis at intel.com>
>>> ---
>>> tests/intel/xe_sriov_auto_provisioning.c | 399
>>> +++++++++++++++++++++++
>>> tests/meson.build | 1 +
>>> 2 files changed, 400 insertions(+)
>>> create mode 100644 tests/intel/xe_sriov_auto_provisioning.c
>>>
>>> diff --git a/tests/intel/xe_sriov_auto_provisioning.c b/tests/intel/
>>> xe_sriov_auto_provisioning.c
>>> new file mode 100644
>>> index 000000000..a5ae60525
>>> --- /dev/null
>>> +++ b/tests/intel/xe_sriov_auto_provisioning.c
>>> @@ -0,0 +1,399 @@
>>> +// SPDX-License-Identifier: MIT
>>> +/*
>>> + * Copyright(c) 2023 Intel Corporation. All rights reserved.
>>> + */
>>> +
>>> +#include <stdbool.h>
>>> +
>>> +#include "drmtest.h"
>>> +#include "igt_core.h"
>>> +#include "igt_sriov_device.h"
>>> +#include "igt_sysfs.h"
>>> +#include "xe/xe_sriov_debugfs.h"
>>> +#include "xe/xe_sriov_provisioning.h"
>>> +#include "xe/xe_query.h"
>>> +
>>> +/**
>>> + * TEST: xe_sriov_auto_provisioning
>>> + * Category: Core
>>> + * Mega feature: SR-IOV
>>> + * Sub-category: provisioning
>>> + * Functionality: auto-provisioning
>>> + * Run type: FULL
>>> + * Description: Examine behavior of SR-IOV auto-provisioning
>>> + *
>>> + * SUBTEST: auto-provisioning-fair
>>
>> As we have auto_provisioning in the test name then maybe subtest
>> named "fair" would be sufficient?
>
> maybe fair-allocation ?
Yeah, sounds better.
>
>>
>>> + * Description:
>>> + * Verify that auto-provisioned resources are allocated by PF
>>> driver in fairly manner
>>> + *
>>> + * SUBTEST: auto-provisioned-resources-released-on-vfs-disabling
>>
>> Similar to the above, maybe "resources-releasing-on-vfs-disabling"?
>
> ok
>
>>
>>> + * Description:
>>> + * Verify that auto-provisioned resources are released once VFs
>>> are disabled
>>> + *
>>> + * SUBTEST: exclusive-ranges
>>> + * Description:
>>> + * Verify that ranges of auto-provisioned resources are exclusive
>>> + */
>>> +
>>> +IGT_TEST_DESCRIPTION("Xe tests for SR-IOV auto-provisioning");
>>> +
>>> +static int compare_ranges_by_vf_id(const void *a, const void *b)
>>> +{
>>> + const struct xe_sriov_provisioned_range *range_a = a;
>>> + const struct xe_sriov_provisioned_range *range_b = b;
>>> +
>>> + return (range_a->vf_id - range_b->vf_id);
>>> +}
>>> +
>>> +static int validate_vf_ids(enum xe_sriov_shared_res res,
>>> + struct xe_sriov_provisioned_range *ranges,
>>> + unsigned int nr_ranges, unsigned int num_vfs)
>>> +{
>>> + unsigned int current_vf_id = 0;
>>> +
>>> + igt_assert(num_vfs);
>>> +
>>> + if (igt_debug_on_f(nr_ranges == 0,
>>> + "%s: No VF ranges\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res)))
>>> + return -ENOENT;
>>> +
>>> + igt_assert(ranges);
>>> + qsort(ranges, nr_ranges, sizeof(ranges[0]),
>>> compare_ranges_by_vf_id);
>>> +
>>> + for (unsigned int i = 0; i < nr_ranges; i++) {
>>> + unsigned int vf_id = ranges[i].vf_id;
>>> +
>>> + /* Skip duplicates */
>>> + if (vf_id == current_vf_id)
>>> + continue;
>>> +
>>> + if (igt_debug_on_f(vf_id < 1 || vf_id > num_vfs,
>>> + "%s: Out of range VF%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), vf_id))
>>> + return -ERANGE;
>>> +
>>> + if (igt_debug_on_f(vf_id > current_vf_id + 1,
>>> + "%s: Missing VF%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res),
>>> + current_vf_id + 1))
>>> + return -ESRCH;
>>> +
>>> + current_vf_id = vf_id;
>>> + }
>>> +
>>> + if (igt_debug_on_f(current_vf_id != num_vfs,
>>> + "%s: Missing VF%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), num_vfs))
>>> + return -ESRCH;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +/* Expects ranges sorted by VF IDs */
>>> +static int validate_fair_allocation(enum xe_sriov_shared_res res,
>>> + struct xe_sriov_provisioned_range *ranges,
>>> + unsigned int nr_ranges)
>>> +{
>>> + uint64_t expected_allocation = 0;
>>> + uint64_t current_allocation = 0;
>>> + unsigned int current_vf_id;
>>> +
>>> + igt_assert(nr_ranges);
>>> + current_vf_id = ranges[0].vf_id;
>>> +
>>> + for (unsigned int i = 0; i <= nr_ranges; i++) {
>>> + if (i == nr_ranges || ranges[i].vf_id != current_vf_id) {
>>> + /* Check allocation consistency for the previous VF ID */
>>> + if (expected_allocation == 0)
>>> + expected_allocation = current_allocation;
>>> + else if (igt_debug_on_f(current_allocation !=
>>> expected_allocation,
>>> + "%s: Allocation mismatch, expected=%lu
>>> VF%u=%lu\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res),
>>> + expected_allocation, current_vf_id,
>>> + current_allocation))
>>> + return -1;
>>> +
>>> + /* Reset for the new VF ID (if not at the end) */
>>> + if (i < nr_ranges) {
>>> + current_vf_id = ranges[i].vf_id;
>>> + current_allocation = 0;
>>> + }
>>> + }
>>> +
>>> + /* Accumulate allocation for the current VF ID */
>>> + if (i < nr_ranges)
>>> + current_allocation += ranges[i].end - ranges[i].start + 1;
>>> + }
>>> +
>>> + return 0;
>>> +}
>>> +
>>
>> Handling cases where one VF can have more than one range of resource
>> adds extra complexity to the test logic. I started wondering if we
>> should consider such case as valid. Maybe we should assert earlier
>> instead?
>
> You mean "+=" complexity ?
>
> current_allocation += ranges[i].end - ranges[i].start + 1;
>
> vs
>
> current_allocation = ranges[i].end - ranges[i].start + 1;
>
>
> and
>
> /* Skip duplicates */
> if (vf_id == current_vf_id)
> continue;
>
> vs
>
> if (vf_id == current_vf_id)
> return err;
>
> in validate_vf_ids ?
>
I though that some conditions and operations are introduced because of
the support of multiple ranges, but that was my misunderstanding. When I
looked on this again, it's fine.
> Maybe we can move the validate_vf_ids to the lib
> or after agree no duplicate ids/gaps allowed return sorted by VF id
> entries from read function ?
>
>>
>>> +static int check_fair_allocation(int pf_fd, unsigned int num_vfs,
>>> unsigned int gt_id,
>>> + enum xe_sriov_shared_res res)
>>> +{
>>> + struct xe_sriov_provisioned_range *ranges;
>>> + unsigned int nr_ranges;
>>> + int ret;
>>> +
>>> + ret = xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res,
>>> gt_id, &ranges, &nr_ranges);
>>> + if (igt_debug_on_f(ret, "Failed read %s on GT%u (%d)\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), gt_id,
>>> ret))
>>> + return ret;
>>> +
>>> + ret = validate_vf_ids(res, ranges, nr_ranges, num_vfs);
>>> + if (ret) {
>>> + free(ranges);
>>> + return ret;
>>> + }
>>> +
>>> + ret = validate_fair_allocation(res, ranges, nr_ranges);
>>> + if (ret) {
>>> + free(ranges);
>>> + return ret;
>>> + }
>>> +
>>> + free(ranges);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static void auto_provisioning_fair(int pf_fd, unsigned int num_vfs)
>>> +{
>>> + enum xe_sriov_shared_res res;
>>> + unsigned int gt;
>>> + int fails = 0;
>>> +
>>> + igt_sriov_disable_driver_autoprobe(pf_fd);
>>> + igt_sriov_enable_vfs(pf_fd, num_vfs);
>>> +
>>> + xe_for_each_gt(pf_fd, gt) {
>>> + xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
>>
>> I was OK with not defining dynamic subtest per GT to reduce the test
>> execution time, but I had mixed feelings about not having separate
>> subtests per resource.
>> But the more I think about it, the more I'm convinced to your
>> approach. For manual reproduction with specific resource we can
>> define some test option taking the resource we want to validate (no
>> need to implement it now, we can add it when needed).
>
> I don't have a strong opinion on this. The dynamic subtest logic
> remains unchanged from the original version, except for the last
> exclusive-ranges subtest, which was adjusted for consistency. We may
> have fewer subtests/statistics, but each subtest should correctly
> report if any resource "misbehaves".
>
> Thanks for review,
> marcin
>>
>>> + if (igt_debug_on_f(check_fair_allocation(pf_fd,
>>> num_vfs, gt, res),
>>> + "%s fair allocation failed on gt%u\n",
>>> + xe_sriov_shared_res_to_string(res), gt))
>>> + fails++;
>>> + }
>>> + }
>>> +
>>> + igt_sriov_disable_vfs(pf_fd);
>>> +
>>> + igt_fail_on_f(fails, "fair allocation failed\n");
>>> +}
>>> +
>>> +static void auto_provisioning_release(int pf_fd, unsigned int num_vfs)
>>> +{
>>> + struct xe_sriov_provisioned_range *ranges;
>>> + unsigned int nr_ranges;
>>> + enum xe_sriov_shared_res res;
>>> + unsigned int gt;
>>> + int fails = 0;
>>> +
>>> + igt_sriov_disable_driver_autoprobe(pf_fd);
>>> + igt_sriov_enable_vfs(pf_fd, num_vfs);
>>> +
>>> + xe_for_each_gt(pf_fd, gt) {
>>> + xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
>>> + if
>>> (igt_warn_on_f(xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res,
>>> + gt,
>>> + &ranges,
>>> + &nr_ranges),
>>> + "Failed read %s on gt%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), gt)) {
>>> + continue;
>>> + }
>>> +
>>> + igt_warn_on_f(validate_vf_ids(res, ranges, nr_ranges,
>>> num_vfs),
>>> + "%s: VF IDs validation failed on gt%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), gt);
>>> + free(ranges);
>>> + }
>>> + }
>>> +
>>> + igt_sriov_disable_vfs(pf_fd);
>>> +
>>> + xe_for_each_gt(pf_fd, gt) {
>>> + xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
>>> + if
>>> (igt_debug_on_f(xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res,
>>> + gt,
>>> + &ranges,
>>> + &nr_ranges),
>>> + "Failed read %s on gt%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), gt)) {
>>> + fails++;
>>> + continue;
>>> + }
>>> +
>>> + if (igt_debug_on_f(nr_ranges,
>>> + "%s contains unexpected ranges on gt%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), gt)) {
>>> + fails++;
>>> + for (unsigned int i = 0; i < nr_ranges; i++) {
>>> + igt_debug((res == XE_SRIOV_SHARED_RES_GGTT) ?
>>> + "%s:VF%u: %lx-%lx\n" :
>>> + "%s:VF%u %lu-%lu\n",
>>> + xe_sriov_shared_res_to_string(res),
>>> + ranges[i].vf_id, ranges[i].start,
>>> ranges[i].end);
>>> + }
>>> + }
>>> + free(ranges);
>>> + }
>>> + }
>>> +
>>> + igt_fail_on_f(fails, "shared resource release check failed\n");
>>> +}
>>> +
>>> +static int compare_ranges_by_start(const void *a, const void *b)
>>> +{
>>> + const struct xe_sriov_provisioned_range *range_a = a;
>>> + const struct xe_sriov_provisioned_range *range_b = b;
>>> +
>>> + if (range_a->start < range_b->start)
>>> + return -1;
>>> + if (range_a->start > range_b->start)
>>> + return 1;
>>> + return 0;
>>> +}
>>> +
>>> +static int check_no_overlap(int pf_fd, unsigned int num_vfs,
>>> unsigned int gt_id,
>>> + enum xe_sriov_shared_res res)
>>> +{
>>> + struct xe_sriov_provisioned_range *ranges;
>>> + unsigned int nr_ranges;
>>> + int ret;
>>> +
>>> + ret = xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res,
>>> gt_id, &ranges, &nr_ranges);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + ret = validate_vf_ids(res, ranges, nr_ranges, num_vfs);
>>> + if (ret) {
>>> + free(ranges);
>>> + return ret;
>>> + }
>>> +
>>> + igt_assert(ranges);
>>> + qsort(ranges, nr_ranges, sizeof(ranges[0]),
>>> compare_ranges_by_start);
>>> +
>>> + for (unsigned int i = 0; i < nr_ranges - 1; i++)
>>> + if (ranges[i].end >= ranges[i + 1].start) {
>>> + igt_debug((res == XE_SRIOV_SHARED_RES_GGTT) ?
>>> + "Overlapping ranges: VF%u [%lx-%lx] and VF%u
>>> [%lx- %lx]\n" :
>>> + "Overlapping ranges: VF%u [%lu-%lu] and VF%u
>>> [%lu- %lu]\n",
>>> + ranges[i].vf_id, ranges[i].start, ranges[i].end,
>>> + ranges[i + 1].vf_id, ranges[i + 1].start,
>>> ranges[i + 1].end);
>>> + free(ranges);
>>> + return -1;
>>> + }
>>> +
>>> + free(ranges);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static void auto_provisioning_exclusive_ranges(int pf_fd, unsigned
>>> int num_vfs)
>>> +{
>>> + enum xe_sriov_shared_res res;
>>> + unsigned int gt;
>>> + int fails = 0;
>>> +
>>> + igt_sriov_disable_driver_autoprobe(pf_fd);
>>> + igt_sriov_enable_vfs(pf_fd, num_vfs);
>>> +
>>> + xe_for_each_gt(pf_fd, gt) {
>>> + xe_sriov_for_each_provisionable_shared_res(res, pf_fd, gt) {
>>> + if (res == XE_SRIOV_SHARED_RES_LMEM)
>>> + /*
>>> + * lmem_provisioned is not applicable for this test,
>>> + * as it does not expose ranges
>>> + */
>>> + continue;
>>> +
>>> + if (igt_debug_on_f(check_no_overlap(pf_fd, num_vfs, gt,
>>> res),
>>> + "%s overlap check failed on gt%u\n",
>>> + xe_sriov_shared_res_to_string(res), gt))
>>> + fails++;
>>> + }
>>> + }
>>> +
>>> + igt_sriov_disable_vfs(pf_fd);
>>> +
>>> + igt_fail_on_f(fails, "exclusive ranges check failed\n");
>>> +}
>>> +
>>> +igt_main
>>> +{
>>> + enum xe_sriov_shared_res res;
>>> + unsigned int gt;
>>> + bool autoprobe;
>>> + int pf_fd;
>>> +
>>> + igt_fixture {
>>> + struct xe_sriov_provisioned_range *ranges;
>>> + unsigned int nr_ranges;
>>> + int ret;
>>> +
>>> + pf_fd = drm_open_driver(DRIVER_XE);
>>> + igt_require(igt_sriov_is_pf(pf_fd));
>>> + igt_require(igt_sriov_get_enabled_vfs(pf_fd) == 0);
>>> +
>>> + xe_for_each_gt(pf_fd, gt) {
>>> + xe_sriov_for_each_provisionable_shared_res(res, pf_fd,
>>> gt) {
>>> + ret =
>>> xe_sriov_pf_debugfs_read_provisioned_ranges(pf_fd, res, gt,
>>> + &ranges,
>>> + &nr_ranges);
>>> + igt_skip_on_f(ret, "Failed read %s on gt%u (%d)\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res),
>>> + gt, ret);
>>> + igt_skip_on_f(nr_ranges != 0, "Unexpected %s
>>> content on gt%u\n",
>>> + xe_sriov_debugfs_provisioned_attr_name(res), gt);
>>> + }
>>> + }
>>> + autoprobe = igt_sriov_is_driver_autoprobe_enabled(pf_fd);
>>> + }
>>> +
>>> + igt_describe("Verify that auto-provisioned resources are
>>> allocated by PF driver in fairly manner");
>>> + igt_subtest_with_dynamic("auto-provisioning-fair") {
>>> + for_random_sriov_num_vfs(pf_fd, num_vfs) {
>>> + igt_dynamic_f("numvfs-random") {
>>> + igt_debug("numvfs=%u\n", num_vfs);
>>> + auto_provisioning_fair(pf_fd, num_vfs);
>>> + }
>>> + }
>>> + }
>>> +
>>> + igt_describe("Verify that auto-provisioned resources are
>>> released once VFs are disabled");
>>> + igt_subtest_with_dynamic("auto-provisioned-resources-released-on-
>>> vfs-disabling") {
>>> + for_random_sriov_num_vfs(pf_fd, num_vfs) {
>>> + igt_dynamic_f("numvfs-random") {
>>> + igt_debug("numvfs=%u\n", num_vfs);
>>> + auto_provisioning_release(pf_fd, num_vfs);
>>> + }
>>> + }
>>> + }
>>> +
>>> + igt_describe("Verify that ranges of auto-provisioned resources
>>> are exclusive");
>>> + igt_subtest_with_dynamic_f("exclusive-ranges") {
>>> + unsigned int total_vfs = igt_sriov_get_total_vfs(pf_fd);
>>> +
>>> + igt_skip_on(total_vfs < 2);
>>> +
>>> + for_random_sriov_vf_in_range(pf_fd, 2, total_vfs, num_vfs) {
>>> + igt_dynamic_f("numvfs-random") {
>>> + igt_debug("numvfs=%u\n", num_vfs);
>>> + auto_provisioning_exclusive_ranges(pf_fd, num_vfs);
>>> + }
>>> + }
>>> + }
>>> +
>>> + igt_fixture {
>>> + igt_sriov_disable_vfs(pf_fd);
>>> + /* abort to avoid execution of next tests with enabled VFs */
>>> + igt_abort_on_f(igt_sriov_get_enabled_vfs(pf_fd) > 0,
>>> "Failed to disable VF(s)");
>>> + autoprobe ? igt_sriov_enable_driver_autoprobe(pf_fd) :
>>> + igt_sriov_disable_driver_autoprobe(pf_fd);
>>> + igt_abort_on_f(autoprobe !=
>>> igt_sriov_is_driver_autoprobe_enabled(pf_fd),
>>> + "Failed to restore sriov_drivers_autoprobe
>>> value\n");
>>> + drm_close_driver(pf_fd);
>>> + }
>>> +}
>>> diff --git a/tests/meson.build b/tests/meson.build
>>> index 2724c7a9a..01076f401 100644
>>> --- a/tests/meson.build
>>> +++ b/tests/meson.build
>>> @@ -315,6 +315,7 @@ intel_xe_progs = [
>>> 'xe_vm',
>>> 'xe_waitfence',
>>> 'xe_spin_batch',
>>> + 'xe_sriov_auto_provisioning',
>>> 'xe_sriov_flr',
>>> 'xe_sysfs_defaults',
>>> 'xe_sysfs_preempt_timeout',
>
More information about the igt-dev
mailing list