[PATCH i-g-t 6/8] lib/xe/xe_spin: Move declarations around

[Lucas De Marchi]

On Mon, Jan 06, 2025 at 10:58:26PM +0000, Cavitt, Jonathan wrote:
>-----Original Message-----
>From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Lucas De Marchi
>Sent: Friday, January 3, 2025 11:16 PM
>To: igt-dev at lists.freedesktop.org
>Cc: De Marchi, Lucas <lucas.demarchi at intel.com>
>Subject: [PATCH i-g-t 6/8] lib/xe/xe_spin: Move declarations around
>>
>> xe_spin.h has 3 abstractions:
>>
>> 1) the integration with igt_dummyload
>> 2) xe_spin, the bo to be exec'ed somewhere
>> 3) xe_cork, that resembles more the igt_spin, abstracting the fd, vm,
>>    bind, etc
>>
>> Group them so it's easier to understand each one.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>
>Okay, I think I get it.  We're bundling the various functions declared in xe_spin.h
>by their purpose/interaction with the various structures, yeah?  That makes sense
>to me.

yes. We could also use separate headers for each of them, but they are
so related and in a small number that I felt it's ok to leave in the
same header.


>And even if my understanding of the purpose of this patch is wrong, I don't see
>any harm in applying it, so:
>Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>

thanks
Lucas De Marchi