[PATCH v2] tests/intel/xe_vm: Fixed documentation
Piecielska, Katarzyna
katarzyna.piecielska at intel.com
Thu Jan 9 08:40:38 UTC 2025
Each test should contain only one TEST field.
Add the Functionality field in the subtest section to fix the warnings during the addition of subtests.
Fixes: 4d630db8b8cf ("Check negative cases for vm_create/destroy ioctl")
Cc: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
Signed-off-by: Pravalika Gurram <pravalika.gurram at intel.com>
---
tests/intel/xe_vm.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c index b10269191..42a47ceac 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -2247,18 +2247,10 @@ static void bind_flag_invalid(int fd)
xe_vm_destroy(fd, vm);
}
-/**
- * TEST: Negative test for vm create/destroy ioctl
- * Category: Core
- * Mega feature: General Core features
- * Sub-category: Synchronization
- * Functionality: vm create
- * Test category: negative test
- */
-
/**
* SUBTEST: invalid-flag-%s
* Description: function %arg[1] used in vm create IOCTL to make it fail
+ * Functionality: ioctl_input_validation
* Functionality: fault
^^^ You have double functionality here. Please remove line with 'fault'
With that fixed:
Reviewed-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
Kasia 😊
*
* arg[1]:
@@ -2279,9 +2271,11 @@ static void invalid_flag(int fd, __u32 flags)
/**
* SUBTEST: invalid-extensions
* Description: Check query with invalid extensions returns expected error code
+ * Functionality: ioctl_input_validation
*
* SUBTEST: vm-create-invalid-reserved
* Description: Send query with invalid reserved value for vm_create ioctl
+ * Functionality: ioctl_input_validation
*/
static void invalid_extensions(int fd)
@@ -2309,12 +2303,15 @@ static void vm_create_invalid_reserved(int fd)
/**
* SUBTEST: vm-destroy-invalid-reserved
* Description: Send query with invalid reserved value for vm_destroy ioctl
+ * Functionality: ioctl_input_validation
*
* SUBTEST: invalid-pad
* Description: Check query with invalid pad returns expected error code
+ * Functionality: ioctl_input_validation
*
* SUBTEST: invalid-vm-id
* Description: Check query with invalid vm_id returns expected error code
+ * Functionality: ioctl_input_validation
*/
static void vm_destroy_invalid_reserved(int fd)
--
2.34.1
More information about the igt-dev
mailing list