[PATCH v3 1/2] tests/intel/kms_frontbuffer_tracking: Add skip condition for bmg platform

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Jan 10 14:19:12 UTC 2025


Hi Mohammed,
On 2025-01-09 at 11:26:51 +0530, Mohammed Thasleem wrote:

please also improve subject so we know it from beginning
which skips you added, so better:

[PATCH v3 1/2] tests/intel/kms_frontbuffer_tracking: Skip fbc* tests on BMG

Same note for your other patches, if you know which ones skipped
just write it in subject. The only exception would be if there
are many different tests names skipped, then you could use
generic.

Regards,
Kamil

> FBC test isn't supported on bmg, skip the test on this platform.
> 
> v2: Add workaround id: Wa_16023588340. (Swati)
> v3: Add workaround id in code.
> 
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
> ---
>  tests/intel/kms_frontbuffer_tracking.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index e41ee0a80..2d47194dd 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -2756,6 +2756,10 @@ static void prepare_subtest_data(const struct test_mode *t,
>  
>  static void prepare_subtest_screens(const struct test_mode *t)
>  {
> +	/* FBC disabled: Wa_16023588340 */
> +	igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t->feature == FEATURE_FBC),
> +		      "FBC isn't supported on BMG\n");
> +
>  	if (t->pipes == PIPE_DUAL)
>  		enable_both_screens_and_wait(t);
>  	else
> @@ -2800,6 +2804,10 @@ static void prepare_subtest(const struct test_mode *t,
>   */
>  static void rte_subtest(const struct test_mode *t)
>  {
> +	/* FBC disabled: Wa_16023588340 */
> +	igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t->feature == FEATURE_FBC),
> +		      "FBC isn't supported on BMG\n");
> +
>  	prepare_subtest_data(t, NULL);
>  
>  	unset_all_crtcs();
> @@ -4285,6 +4293,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>  			t.flip = -1;
>  			t.tiling = opt.tiling;
>  
> +			/* FBC disabled: Wa_16023588340 */
> +			igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t.feature == FEATURE_FBC),
> +				      "FBC isn't supported on BMG\n");
> +
>  			for_each_pipe(&drm.display, pipe) {
>  				if (pipe == default_pipe) {
>  					igt_info("pipe-%s: FBC validated in other subtest\n", kmstest_pipe_name(pipe));
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list