[PATCH i-g-t v3] tests/intel/kms_fbcon_fbt: Add skip condition for bmg platform

[Kamil Konieczny]

Hi Thasleem,
On 2025-01-03 at 14:22:39 +0000, Samala, Pranay wrote:
> Hi Thasleem,
> 
> > -----Original Message-----
> > From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Mohammed
> > Thasleem
> > Sent: Friday, January 3, 2025 5:27 PM
> > To: igt-dev at lists.freedesktop.org
> > Cc: Thasleem, Mohammed <mohammed.thasleem at intel.com>
> > Subject: [PATCH i-g-t v3] tests/intel/kms_fbcon_fbt: Add skip condition for bmg
> > platform

Please improve subject a little:
[PATCH i-g-t v3] tests/intel/kms_fbcon_fbt: Skip FBC testing on BMG platform

> > 
> > FBC test isn't supported on bmg, skip the test on this platform.
> > 
> > v2: Add workaround id: Wa_16023588340. (Pranay)
> >     Use IS_BATTLEMAGE check instead using devid.
> > v3: Add workaround id in code.
> > 
> > Signed-off-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
> Please add Reviewed-by as RB is not reflecting.
> 
> Thanks and Regards,
> Pranay Samala

This and above could be done at merge but first please also
reply to CI failure and inform that SKIP on BMG is desired,
so our bug filing team could improve filters.

Inform them also about non-related reported failures.

Regards,
Kamil

> > ---
> >  tests/intel/kms_fbcon_fbt.c | 17 ++++++++++++++---
> >  1 file changed, 14 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c index
> > ab4819d23..9c3ff7a21 100644
> > --- a/tests/intel/kms_fbcon_fbt.c
> > +++ b/tests/intel/kms_fbcon_fbt.c
> > @@ -73,7 +73,7 @@ IGT_TEST_DESCRIPTION("Test the relationship between
> > fbcon and the frontbuffer "
> >  #define MAX_CONNECTORS 32
> > 
> >  struct drm_info {
> > -	int fd, debugfs_fd, crtc_id;
> > +	int fd, debugfs_fd, crtc_id, devid;
> >  	struct igt_fb fb;
> >  	drmModeResPtr res;
> >  	drmModeConnectorPtr connectors[MAX_CONNECTORS]; @@ -418,6
> > +418,8 @@ static void setup_environment(struct drm_info *drm)
> >  	igt_require(drm->fd >= 0);
> >  	drm->debugfs_fd = igt_debugfs_dir(drm->fd);
> >  	igt_require(drm->debugfs_fd >= 0);
> > +	drm->devid = intel_get_drm_devid(drm->fd);
> > +	igt_require(drm->devid >= 0);
> > 
> >  	drm->res = drmModeGetResources(drm->fd);
> >  	igt_require(drm->res);
> > @@ -457,16 +459,25 @@ igt_main
> > 
> >  	igt_describe("Test the relationship between fbcon and the frontbuffer "
> >  		     "tracking infrastructure with fbc enabled.");
> > -	igt_subtest("fbc")
> > +	igt_subtest("fbc") {
> > +		/* FBC disabled: Wa_16023588340 */
> > +		igt_require_f(!IS_BATTLEMAGE(drm.devid), "FBC isn't supported
> > on
> > +BMG\n");
> >  		subtest(&drm, &fbc, false);
> > +	}
> > +
> >  	igt_describe("Test the relationship between fbcon and the frontbuffer "
> >  		     "tracking infrastructure with psr enabled.");
> >  	igt_subtest("psr")
> >  		subtest(&drm, &psr, false);
> > +
> >  	igt_describe("Suspend test to validate  the relationship between fbcon
> > and the frontbuffer "
> >  		     "tracking infrastructure with fbc enabled.");
> > -	igt_subtest("fbc-suspend")
> > +	igt_subtest("fbc-suspend") {
> > +		/* FBC disabled: Wa_16023588340 */
> > +		igt_require_f(!IS_BATTLEMAGE(drm.devid), "FBC isn't supported
> > on
> > +BMG\n");
> >  		subtest(&drm, &fbc, true);
> > +	}
> > +
> >  	igt_describe("Suspend test to validate the relationship between fbcon
> > and the frontbuffer "
> >  		     "tracking infrastructure with psr enabled.");
> >  	igt_subtest("psr-suspend")
> > --
> > 2.34.1
>