[PATCH i-g-t] tests/intel/gem_exec_balancer: Decrease expected load value
Kamil Konieczny
kamil.konieczny at linux.intel.com
Wed Jan 15 14:25:58 UTC 2025
Hi Sebastian,
On 2024-12-17 at 15:01:10 +0000, Sebastian Brzezinka wrote:
> Expected value of 0.90 may occasionally not be achieved, either be
> latency in the scheduler, or perf reporting. I'm lowering it to 0.85
> to match actual values (87.5% in last fail).
>
> Resolves: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12943
>
This empty line should be removed.
> Signed-off-by :Sebastian Brzezinka <sebastian.brzezinka at intel.com>
there is space before colon ' :S' it should be:
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka at intel.com>
Please use checkpatch.pl script from linux kernel also for igt,
you could find few helpfull options in CONTRIBUTING.md
Also I just noticed after a merge that you sent it without
r-b from Andi... and I forgot to cross-check mailing list...
Please remember to add r-b if it was given,
unless you make changes after that which justify removing r-b.
Your patch is now applied, thank you for contributing!
Regards,
Kamil
PS. Sorry Andi for missing your r-b, I tried to find out what todo
only on patchwork, what is strange your mail didn't get into patchwork.
> ---
> tests/intel/gem_exec_balancer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/gem_exec_balancer.c b/tests/intel/gem_exec_balancer.c
> index e7c43f1b4..c3f0c938b 100644
> --- a/tests/intel/gem_exec_balancer.c
> +++ b/tests/intel/gem_exec_balancer.c
> @@ -614,7 +614,7 @@ static void check_individual_engine(int i915,
>
> close(pmu);
>
> - igt_assert_f(load > 0.90,
> + igt_assert_f(load > 0.85,
> "engine %d (class:instance %d:%d) was found to be only %.1f%% busy\n",
> idx, ci[idx].engine_class, ci[idx].engine_instance, load*100);
> }
> --
> 2.34.1
>
More information about the igt-dev
mailing list