[PATCH v3] tests/intel: Enhance the wedged_mode sysfs support

[Kamil Konieczny]

Hi Pravalika,
On 2025-01-13 at 19:21:03 +0530, Pravalika Gurram wrote:

please add in subject a test name, also write what you did
in a few words, so intestead of:
tests/intel: Enhance the wedged_mode sysfs support

better:
tests/intel/xe_wedged: Add debugfs reading subtest

> Added support to read the wedged_mode sysfs

s/sysfs/debugfs/

Above could be changed at merge time, so you could leave
that for now. One more nit below.

> 
> Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> Signed-off-by: Pravalika Gurram <pravalika.gurram at intel.com>
> ---
>  tests/intel/xe_wedged.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/tests/intel/xe_wedged.c b/tests/intel/xe_wedged.c
> index 613d571b4..844ab2809 100644
> --- a/tests/intel/xe_wedged.c
> +++ b/tests/intel/xe_wedged.c
> @@ -203,11 +203,16 @@ simple_hang(int fd, struct drm_xe_sync *sync)
>   * SUBTEST: wedged-mode-toggle
>   * Description: Test wedged.mode=1 after testing wedged.mode=2
>   */
> +/**
> + * SUBTEST: basic-wedged-read
> + * Description: Read wedged debugfs
> + */
>  igt_main
>  {
>  	struct drm_xe_engine_class_instance *hwe;
>  	int fd;
>  	char pci_slot[NAME_MAX];
> +	char str[150];

This should go into subtest, not here, see below.

>  
>  	igt_fixture {
>  		fd = drm_open_driver(DRIVER_XE);
> @@ -279,6 +284,13 @@ igt_main
>  		igt_assert_eq(simple_ioctl(fd), 0);
>  	}
>  
> +	igt_subtest_f("basic-wedged-read") {

Add here:
		char str[150] = { 0 };

With this addressed
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> +		igt_require(igt_debugfs_exists(fd, "wedged_mode", O_RDONLY));
> +
> +		igt_debugfs_read(fd, "wedged_mode", str);
> +		igt_assert_f(str[0] != '\0', "Failed to read wedged_mode from debugfs!\n");
> +	}
> +
>  	igt_fixture {
>  		if (igt_debugfs_exists(fd, "fail_gt_reset/probability", O_RDWR)) {
>  			igt_debugfs_write(fd, "fail_gt_reset/probability", "0");
> -- 
> 2.34.1
>