[PATCH i-g-t v2 3/7] runner/settings: Drop extra strdup

[Peter Senna Tschudin]

On 22.01.2025 12:34, Gustavo Sousa wrote:
> Quoting Lucas De Marchi (2025-01-21 19:57:29-03:00)
>> No need to strdup() again since the fscanf() function is already
>> allocating the variable. Just set the pointer to NULL so we "leak" our
>> variable to be saved in the settings.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> ---
>> runner/settings.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/runner/settings.c b/runner/settings.c
>> index 13694a51c..96377f1de 100644
>> --- a/runner/settings.c
>> +++ b/runner/settings.c
>> @@ -1164,7 +1164,11 @@ static unsigned long parse_ul(char **pval)
>>
>> static char *parse_str(char **pval)
>> {
>> -        return *pval ? strdup(*pval) : NULL;
>> +        char *ret = *pval;
>> +
>> +        *pval = NULL;
> 
> Okay. This explains the need for char **pval in the previous patch.
> Maybe a heads up in #2's commit message would clarify things :-)
> 
> Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>
Tested-by: Peter Senna Tschudin <peter.senna at linux.intel.com>
Reviewed-by: Peter Senna Tschudin <peter.senna at linux.intel.com>
> 
>> +
>> +        return ret;
>> }
>>
>> #define PARSE_LINE(s, name, val, field, _f)        \
>> -- 
>> 2.48.0
>>