[PATCH i-g-t] tests/intel/kms_dp_linktrain_fallback: Reduce debug loglevel dynamically

[B, Jeevan]

LGTM.

Reviewed-by: Jeevan B <jeevan.b at intel.com>

> -----Original Message-----
> From: Samala, Pranay <pranay.samala at intel.com>
> Sent: Wednesday, January 29, 2025 11:20 AM
> To: B, Jeevan <jeevan.b at intel.com>; igt-dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Joshi, Kunal1 <kunal1.joshi at intel.com>;
> Lattannavar, Sameer <sameer.lattannavar at intel.com>
> Subject: RE: [PATCH i-g-t] tests/intel/kms_dp_linktrain_fallback: Reduce debug
> loglevel dynamically
> 
> HI Jeevan,
> 
> > -----Original Message-----
> > From: B, Jeevan <jeevan.b at intel.com>
> > Sent: Wednesday, January 29, 2025 11:10 AM
> > To: Samala, Pranay <pranay.samala at intel.com>;
> > igt-dev at lists.freedesktop.org
> > Cc: B S, Karthik <karthik.b.s at intel.com>; Joshi, Kunal1
> > <kunal1.joshi at intel.com>; Lattannavar, Sameer
> > <sameer.lattannavar at intel.com>; Samala, Pranay
> > <pranay.samala at intel.com>
> > Subject: RE: [PATCH i-g-t] tests/intel/kms_dp_linktrain_fallback:
> > Reduce debug loglevel dynamically
> >
> > > -----Original Message-----
> > > From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> > > Pranay Samala
> > > Sent: Thursday, January 9, 2025 10:37 PM
> > > To: igt-dev at lists.freedesktop.org
> > > Cc: B S, Karthik <karthik.b.s at intel.com>; Joshi, Kunal1
> > > <kunal1.joshi at intel.com>; Lattannavar, Sameer
> > > <sameer.lattannavar at intel.com>; Samala, Pranay
> > > <pranay.samala at intel.com>
> > > Subject: [PATCH i-g-t] tests/intel/kms_dp_linktrain_fallback: Reduce
> > > debug loglevel dynamically
> > >
> > > This test is getting incomplete on CI environment because its
> > > logging to many logs.
> > >
> > > So dynamically reducing the debug log level to 10.
> > >
> > > Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> > > ---
> > >  tests/intel/kms_dp_linktrain_fallback.c | 11 ++++++++++-
> > >  1 file changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tests/intel/kms_dp_linktrain_fallback.c
> > > b/tests/intel/kms_dp_linktrain_fallback.c
> > > index a05e2015f..415005774 100644
> > > --- a/tests/intel/kms_dp_linktrain_fallback.c
> > > +++ b/tests/intel/kms_dp_linktrain_fallback.c
> > > @@ -14,7 +14,7 @@
> > >   */
> > >
> > >  #include <sys/types.h>
> > > -
> > > +#include "igt_sysfs.h"
> > >  #include "igt.h"
> > >
> > >  /**
> > > @@ -391,6 +391,7 @@ igt_main
> > >  	data_t data = {};
> > >
> > >  	igt_fixture {
> > > +		int dir, current_log_level;
> > >  		data.drm_fd = drm_open_driver_master(DRIVER_INTEL |
> > >  						     DRIVER_XE);
> > >  		kmstest_set_vt_graphics_mode();
> > > @@ -398,6 +399,14 @@ igt_main
> > >  		igt_display_require_output(&data.display);
> > >  		for_each_pipe(&data.display, data.pipe)
> > >  			data.n_pipes++;
> > > +		dir = igt_sysfs_drm_module_params_open();
> > > +		if (dir >= 0) {
> > > +			current_log_level = igt_drm_debug_level_get(dir);
> > > +			close(dir);
> > > +
> > > +			if (current_log_level > 10)
> > > +				igt_drm_debug_level_update(10);
> > > +		}
> > Once we have completed this test we need to restore the log-level else
> > this will affect the rest of the grid.
> 
> Exit handler is being called in this function igt_drm_debug_level_update, and it
> will restore the log level while exiting the test.
> 
> Regards,
> Pranay
> > >  	}
> > >
> > >  	igt_subtest("dp-fallback") {
> > > --
> > > 2.34.1