[PATCH i-g-t 2/3] tests/intel/xe_create: Stop treating the extension field as MBZ

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Jan 31 17:28:48 UTC 2025


Hi Daniele,
On 2025-01-31 at 09:09:43 -0800, Daniele Ceraolo Spurio wrote:
> 
> 
> On 1/31/2025 4:59 AM, Kamil Konieczny wrote:
> > Hi Daniele,
> > On 2025-01-30 at 14:14:56 -0800, Daniele Ceraolo Spurio wrote:
> > > A new extension for the xe_create ioctl will be added to support PXP [1],
> > > so in preparation for that to be merged stop expecting the field to always
> > > be zero.
> > > 
> > > [1] https://patchwork.freedesktop.org/patch/634550/
> > Please add also lore.kernel.org link (could be done at merge)
> > here and in next patch, Thanks!
> 
> Should I just replace this link instead of adding a new one?

Write both links or only lore, up to you.
Please note that sometimes links get lost so it could help giving
also a subject of patch(series) (for example above in next line
after [1]).

Regards,
Kamil

> 
> Thanks,
> Daniele
> 
> > 
> > Regards,
> > Kamil
> > 
> > > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > > Reviewed-by: Alan Previn <alan.previn.teres.alexis at intel.com>
> > > ---
> > >   tests/intel/xe_create.c | 5 -----
> > >   1 file changed, 5 deletions(-)
> > > 
> > > diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
> > > index e3be6b774..e3ebb9fd4 100644
> > > --- a/tests/intel/xe_create.c
> > > +++ b/tests/intel/xe_create.c
> > > @@ -243,11 +243,6 @@ static void create_invalid_mbz(int fd)
> > >   	gem_close(fd, create.handle);
> > >   	create.handle = 0;
> > > -	/* No supported extensions yet */
> > > -	create.extensions = -1;
> > > -	igt_assert_eq(__ioctl_create(fd, &create), -EINVAL);
> > > -	create.extensions = 0;
> > > -
> > >   	/* Make sure KMD rejects non-zero padding/reserved fields */
> > >   	for (i = 0; i < ARRAY_SIZE(create.pad); i++) {
> > >   		create.pad[i] = -1;
> > > -- 
> > > 2.43.0
> > > 
> 


More information about the igt-dev mailing list