[PATCH i-g-t v1 2/2] tests/kms_flip: Remove assertion dependency on link reset retry condition

Naladala Ramanaidu ramanaidu.naladala at intel.com
Tue Jul 1 11:01:49 UTC 2025


This change avoids test failures in scenarios where hotplug detection
is inconclusive or delayed. The call to link reset is retained for
its potential side effects or logging purposes, but it is no longer
part of the assertion condition.

Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
---
 tests/kms_flip.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 4dfa1c483..8ce164202 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1641,7 +1641,9 @@ retry:
 
 	/* quiescent the hw a bit so ensure we don't miss a single frame */
 	if (o->flags & TEST_CHECK_TS && !calibrate_ts(o, crtc_idxs[0])) {
-		igt_assert(!retried && needs_retry_after_link_reset(mon));
+		igt_assert(!retried);
+
+		needs_retry_after_link_reset(mon);
 
 		retried = true;
 
@@ -1680,7 +1682,9 @@ retry:
 		state_ok &= check_final_state(o, &o->vblank_state, elapsed);
 
 	if (!state_ok) {
-		igt_assert(!retried && needs_retry_after_link_reset(mon));
+		igt_assert(!retried);
+
+		needs_retry_after_link_reset(mon);
 
 		retried = true;
 
-- 
2.43.0



More information about the igt-dev mailing list