[PATCH igt 9/9] msm/mapping: Free devcore

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Jul 1 16:27:16 UTC 2025


Hi Rob,
On 2025-06-30 at 11:09:03 -0700, Rob Clark wrote:
> From: Rob Clark <rob.clark at oss.qualcomm.com>

imho:

[PATCH i-g-t 9/9] tests/msm/msm_mapping: Fix memory leak

Also imho this should be your first patch, so fixes first,
but it is up to you.

Regards,
Kamil

> 
> We shouldn't leak the devcore.
> 
> Signed-off-by: Rob Clark <rob.clark at oss.qualcomm.com>
> ---
>  tests/msm/msm_mapping.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/msm/msm_mapping.c b/tests/msm/msm_mapping.c
> index 7e2f5c7eadc8..b735d5f014c3 100644
> --- a/tests/msm/msm_mapping.c
> +++ b/tests/msm/msm_mapping.c
> @@ -249,6 +249,8 @@ do_mapping_test(struct msm_pipe *pipe, const char *buffername, bool write)
>  	igt_fail_on(ret != 1);
>  	igt_fail_on(addr != fault_addr);
>  
> +	free(devcore);
> +
>  	/* Wait for stall-on-fault to re-enable, otherwise the next sub-test
>  	 * would not generate a devcore:
>  	 */
> -- 
> 2.50.0
> 


More information about the igt-dev mailing list