[PATCH i-g-t v2 2/2] tests/kms_flip: Remove assertion dependency on link reset retry condition

[Karthik B S]

On 7/2/2025 11:04 AM, Naladala Ramanaidu wrote:
> This change avoids test failures in scenarios where hotplug detection
> is inconclusive or delayed. The call to link reset is retained for
> its potential side effects or logging purposes, but it is no longer
> part of the assertion condition.
>
> rev2: Fix review comments. (Karthik)
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
Reviewed-by: Karthik B S <karthik.b.s at intel.com>
> ---
>   tests/kms_flip.c | 22 ++++++++++++++++++++--
>   1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 4dfa1c483..382b92d9a 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1641,7 +1641,16 @@ retry:
>   
>   	/* quiescent the hw a bit so ensure we don't miss a single frame */
>   	if (o->flags & TEST_CHECK_TS && !calibrate_ts(o, crtc_idxs[0])) {
> -		igt_assert(!retried && needs_retry_after_link_reset(mon));
> +		igt_assert(!retried);
> +
> +		/*
> +		 * FIXME: Retried logic is currently breaking due to an HPD
> +		 * (Hot Plug Detect) issue. Temporarily removing this from
> +		 * the assertion. This needs to be debugged separately.
> +		 * Revert this patch once the HPD issue is resolved.
> +		 */
> +		if (!needs_retry_after_link_reset(mon))
> +			igt_debug("Retrying without a hotplug event\n");
>   
>   		retried = true;
>   
> @@ -1680,7 +1689,16 @@ retry:
>   		state_ok &= check_final_state(o, &o->vblank_state, elapsed);
>   
>   	if (!state_ok) {
> -		igt_assert(!retried && needs_retry_after_link_reset(mon));
> +		igt_assert(!retried);
> +
> +		/*
> +		 * FIXME: Retried logic is currently breaking due to an HPD
> +		 * (Hot Plug Detect) issue. Temporarily removing this from
> +		 * the assertion. This needs to be debugged separately.
> +		 * Revert this patch once the HPD issue is resolved.
> +		 */
> +		if (!needs_retry_after_link_reset(mon))
> +			igt_debug("Retrying without a hotplug event\n");
>   
>   		retried = true;
>