[i-g-t] tests/intel/xe_dma_buf_sync.c: Ensure spinner completion
Kamil Konieczny
kamil.konieczny at linux.intel.com
Wed Jul 2 11:51:07 UTC 2025
Hi Cavitt,,
On 2025-07-01 at 16:59:57 +0000, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Kamil Konieczny
> Sent: Friday, June 27, 2025 9:39 AM
> To: Randhawa, Jagmeet <jagmeet.randhawa at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Brost, Matthew <matthew.brost at intel.com>; Nguyen, Brian3 <brian3.nguyen at intel.com>
> Subject: Re: [i-g-t] tests/intel/xe_dma_buf_sync.c: Ensure spinner completion
> >
> > On 2025-06-27 at 03:00:02 +0800, Jagmeet Randhawa wrote:
> >
> > One small nit, please remove ".c" from subject, so it will
> > read:
> >
> > [i-g-t] tests/intel/xe_dma_buf_sync: Ensure spinner completion
>
> Agreed. With the above change, this is
> Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> -Jonathan Cavitt
>
Thank you, I merged it.
Regards,
Kamil
> >
> > This could be done at merge time, no need for resend.
> >
> > Regards,
> > Kamil
> >
> > > Add syncobj_wait() to verify that the spinner operation on fd[0]
> > > has completely finished before proceeding to clean up.
> > >
> > > Signed-off-by: Jagmeet Randhawa <jagmeet.randhawa at intel.com>
> > > Cc: Brian Nguyen <brian3.nguyen at intel.com>
> > > Suggested-by: Matthew Brost <matthew.brost at intel.com>
> > > ---
> > > tests/intel/xe_dma_buf_sync.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tests/intel/xe_dma_buf_sync.c b/tests/intel/xe_dma_buf_sync.c
> > > index 3e8d89e95..1c0e7c670 100644
> > > --- a/tests/intel/xe_dma_buf_sync.c
> > > +++ b/tests/intel/xe_dma_buf_sync.c
> > > @@ -203,6 +203,8 @@ test_export_dma_buf(struct drm_xe_engine_class_instance *hwe0,
> > > xe_spin_end(&data[i]->spin);
> > > igt_assert(syncobj_wait(fd[1], &sync[1].handle, 1, INT64_MAX,
> > > 0, NULL));
> > > + igt_assert(syncobj_wait(fd[0], &syncobj_signal, 1, INT64_MAX,
> > > + 0, NULL));
> > > igt_assert_eq(data[i]->data, 0xc0ffee);
> > >
> > > /* Clean up */
> >
More information about the igt-dev
mailing list