[PATCH v3 resend i-g-t 3/6] tests: Add core_debugfs_heads_power

[Kamil Konieczny]

Hi Karthik,
On 2025-07-04 at 15:31:02 +0530, Karthik B S wrote:
> Hi,
> 
> On 7/4/2025 1:36 PM, Peter Senna Tschudin wrote:
> > 
> > On 7/3/2025 10:39 PM, Rodrigo Vivi wrote:
> > > On Mon, Jun 16, 2025 at 09:42:35AM +0200, Peter Senna Tschudin wrote:
> > > > Introduce core_debugfs_heads_power that is expected to work with any
> > > > GPU, not limited to i915 and Xe. The test powers off all available
> > > > heads before reading debugfs files, and then powers on all heads
> > > > before reading the files again.
> > > > 
> > > > Cc: Karthik B S <karthik.b.s at intel.com>
> > > > Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> > > > Cc: Juha-Pekka Heikkila <juha-pekka.heikkila at intel.com>
> > > > Cc: Swati Sharma <swati2.sharma at intel.com>
> > > > Cc: michal.wajdeczko at intel.com
> > > > Cc: marcin.bernatowicz at intel.com
> > > > Cc: kamil.konieczny at linux.intel.com
> > > > Cc: katarzyna.piecielska at intel.com
> > > > Cc: zbigniew.kempczynski at intel.com
> > > > Cc: ewelina.musial at intel.com
> > > > Signed-off-by: Peter Senna Tschudin <peter.senna at linux.intel.com>
> > > > ---
> > > > v3:
> > > >   - renamed the test
> > > >   - Removed reference to sysfs from comments  (thanks Kamil)
> > > >   - Updated description to match the display part (thanks Kamil)
> > > >   - Moved from "display" to "heads". Our CI uses "headless" to refer
> > > >     to a DUT without display and it is shorter
> > > >   - renamed subtests for shorter names (thanks Kamil)
> > > >   - fixed comments style (thanks Kamil)
> > > >   - updated CC list
> > > >   - changed the order to test first with all heads off then with all heads on
> > > >     to prevent the need from powering on the heads at the end of the test
> > > >     (thanks Kamil)
> > > >   - removed snprintf from test names (thanks Kamil)
> > > >   - removed subtest group (thanks Kamil)
> > > >   - deleted kms_tests() and moved the code to igt_main (thanks Kamil)
> > > > 
> > > > v2:
> > > >   - changed style of comparison to NULL
> > > >   - moved to a separate patch
> > > > 
> > > >   tests/core_debugfs_heads_power.c | 156 +++++++++++++++++++++++++++++++
> > > >   tests/meson.build                |   1 +
> > > >   2 files changed, 157 insertions(+)
> > > >   create mode 100644 tests/core_debugfs_heads_power.c
> > > > 
> > > > diff --git a/tests/core_debugfs_heads_power.c b/tests/core_debugfs_heads_power.c
> > > > new file mode 100644
> > > > index 000000000..1813986d8
> > > > --- /dev/null
> > > > +++ b/tests/core_debugfs_heads_power.c
> > > > @@ -0,0 +1,156 @@
> > > > +// SPDX-License-Identifier: MIT
> > > > +/*
> > > > + * Copyright © 2025 Intel Corporation
> > > > + */
> > > > +
> > > > +#include "igt.h"
> > > > +#include "igt_debugfs.h"
> > > > +#include "igt_dir.h"
> > > > +
> > > > +/**
> > > > + * TEST: debugfs heads power test
> > > Could we please use display instead of heads here?
> > >  From display folks perspective heads might be indeed more clear because we will
> > > only use display if any 'head' is attached, but from folks outside of display
> > > world, heads will be a confusing term to be in the name of the test.
> > > 
> > > Or perhaps we name kms_debugfs
> > My first name proposal was core_debugfs_display_on_off. This is
> > informative because it makes it explicit that this runs the test with
> > display on and with the display off. This name is also a good contrast
> > with the other test core_debugfs. Removing the on_off suffix makes the
> > name less informative.
> > 
> > Problem is that core_debugfs_display_on_off is a large name. So using
> > heads instead of display was an attempt to make the name shorter, but no
> > one liked it. We are waiting the KMS team to decide on which name they want.
> I would vote for kms_debugfs as this would be also consistent with the
> existing display tests. I'm also okay with 'core_debugfs_display' if we
> can't have kms_debugfs.

Imho kms_debugfs is good, also shorter.

> > 
> > 
> > 
> > 
> > > > + * Description: Read entries from debugfs with all heads on and with all heads
> > > > + *		off.

Karthik, could you help us with this description here?
Why we need this test, as I guess core_debugfs is not enough,
but why?  Do we need any improvement in testing this?

It could be added as is now as this how it was in Intel tests,
with a note about TODO.

Regards,
Kamil

> > > > + * Category: Core
> > > > + * Mega feature: General Core features
> > > > + * Sub-category: uapi
> > > > + * Functionality: debugfs
> > > > + * Feature: core
> > > > + * Test category: uapi
> > > > + *
> > > > + * SUBTEST: off-read-all
> > > > + * Description: Read all debugfs entries with heads off.
> > > > + *
> > > > + * SUBTEST: on-read-all
> > > > + * Description: Read all debugfs entries with heads on.
> > > > + */

...cut...