[PATCH i-g-t 6/9] lib/colorops: Add support for 1D LUT multi-segmented
Swati Sharma
swati2.sharma at intel.com
Sun Jul 6 20:01:22 UTC 2025
From: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
Add helpers to support 1D LUT multi-segmented.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
---
tests/kms_color_helper.c | 100 +++++++++++++++++++++++++++++++++++++++
tests/kms_color_helper.h | 29 ++++++++++++
2 files changed, 129 insertions(+)
diff --git a/tests/kms_color_helper.c b/tests/kms_color_helper.c
index ded61ccad..c5f2dcc20 100644
--- a/tests/kms_color_helper.c
+++ b/tests/kms_color_helper.c
@@ -24,6 +24,8 @@
#include "kms_color_helper.h"
+#define MIN(a, b) ((a) < (b) ? (a) : (b))
+
bool pipe_output_combo_valid(data_t *data, enum pipe pipe)
{
bool ret = true;
@@ -403,6 +405,10 @@ static bool can_use_colorop(igt_display_t *display, igt_colorop_t *colorop, kms_
if (igt_colorop_get_prop(display, colorop, IGT_COLOROP_TYPE) == DRM_COLOROP_1D_LUT)
return true;
return false;
+ case KMS_COLOROP_MULTSEG_LUT1D:
+ if (igt_colorop_get_prop(display, colorop, IGT_COLOROP_TYPE) == DRM_COLOROP_1D_LUT_MULTSEG)
+ return true;
+ return false;
case KMS_COLOROP_MULTIPLIER:
return (igt_colorop_get_prop(display, colorop, IGT_COLOROP_TYPE) == DRM_COLOROP_MULTIPLIER);
case KMS_COLOROP_LUT3D:
@@ -514,6 +520,9 @@ void set_colorop(igt_display_t *display, kms_colorop_t *colorop)
lut_size = igt_colorop_get_prop(display, colorop->colorop, IGT_COLOROP_SIZE);
igt_colorop_set_custom_1dlut(display, colorop->colorop, colorop->lut1d, lut_size * sizeof(struct drm_color_lut));
break;
+ case KMS_COLOROP_MULTSEG_LUT1D:
+ igt_colorop_set_multseg_1dlut(display, colorop->colorop, colorop->multseg_lut1d_info);
+ break;
case KMS_COLOROP_MULTIPLIER:
mult = colorop->multiplier * (mult << 32); /* convert double to fixed number */
igt_colorop_set_prop_value(colorop->colorop, IGT_COLOROP_MULTIPLIER, mult);
@@ -592,3 +601,94 @@ void igt_colorop_set_3dlut(igt_display_t *display,
{
igt_colorop_replace_prop_blob(colorop, IGT_COLOROP_DATA, lut3d, lut_size);
}
+
+void create_zero_lut(segment_data_t *info, struct drm_color_lut_32 *lut)
+{
+ int i;
+
+ for (i = 0; i < info->entries_count; i++)
+ lut[i].red = lut[i].green = lut[i].blue = 0;
+}
+
+void create_unity_lut(segment_data_t *info, struct drm_color_lut_32 *lut)
+{
+ uint32_t val, segment, entry, index = 0;
+ uint32_t max_val = 0xffffffff;
+
+ for (segment = 0; segment < info->segment_count; segment++) {
+ uint32_t entry_count = info->segment_data[segment].count;
+ uint32_t start = info->segment_data[segment].start;
+ uint32_t end = info->segment_data[segment].end;
+
+ for (entry = 1; entry <= entry_count; entry++) {
+ val = start + entry * ((end - start) * 1.0 / entry_count);
+ lut[index].red = lut[index].green = lut[index].blue =
+ (index == 0) ? 0 : MIN(val, max_val);
+
+ index++;
+ }
+ }
+}
+
+void create_max_lut(segment_data_t *info, struct drm_color_lut_32 *lut)
+{
+ int i;
+ uint32_t max_val = 0xffffffff;
+
+ for (i = 0; i < info->entries_count; i++)
+ lut[i].red = lut[i].green = lut[i].blue = (i == 0) ? 0 : max_val;
+}
+
+void clear_segment_data(segment_data_t *info)
+{
+ if (!info)
+ return;
+
+ free(info->segment_data);
+ free(info);
+}
+
+segment_data_t *get_segment_data(int drm_fd, uint64_t blob_id)
+{
+ drmModePropertyBlobPtr blob;
+ struct drm_color_lut_range *lut_range = NULL;
+ segment_data_t *info = NULL;
+ uint32_t i;
+
+ blob = drmModeGetPropertyBlob(drm_fd, blob_id);
+ igt_assert(blob);
+ igt_assert(blob->length);
+
+ info = malloc(sizeof(segment_data_t));
+ igt_assert(info);
+
+ lut_range = (struct drm_color_lut_range *) blob->data;
+ info->segment_count = blob->length / sizeof(lut_range[0]);
+ igt_assert(info->segment_count);
+
+ info->segment_data = malloc(sizeof(struct drm_color_lut_range) * info->segment_count);
+ igt_assert(info->segment_data);
+
+ info->entries_count = 0;
+ for (i = 0; i < info->segment_count; i++) {
+ info->entries_count += lut_range[i].count;
+ info->segment_data[i] = lut_range[i];
+ }
+
+ drmModeFreePropertyBlob(blob);
+
+ return info;
+}
+
+void igt_colorop_set_multseg_1dlut(igt_display_t *display,
+ igt_colorop_t *colorop,
+ const kms_colorop_multseg_lut1d_info_t lut_info)
+{
+ /* set blob property */
+ for (int i = 0; i < lut_info.lut_size; i++)
+ igt_debug("Lut[%d]: 0x%08x 0x%08x 0x%08x\n",
+ i, lut_info.lut[i].red, lut_info.lut[i].green, lut_info.lut[i].blue);
+
+ igt_colorop_replace_prop_blob(colorop, IGT_COLOROP_DATA,
+ lut_info.lut, sizeof(struct drm_color_lut_32) * lut_info.lut_size);
+}
diff --git a/tests/kms_color_helper.h b/tests/kms_color_helper.h
index 11abe7e46..29efb7e7b 100644
--- a/tests/kms_color_helper.h
+++ b/tests/kms_color_helper.h
@@ -122,10 +122,23 @@ void invalid_gamma_lut_sizes(data_t *data, enum pipe p);
void invalid_degamma_lut_sizes(data_t *data, enum pipe p);
void invalid_ctm_matrix_sizes(data_t *data, enum pipe p);
+typedef struct {
+ uint32_t segment_count;
+ struct drm_color_lut_range *segment_data;
+ uint32_t entries_count;
+} segment_data_t;
+
+void create_zero_lut(segment_data_t *info, struct drm_color_lut_32 *lut);
+void create_unity_lut(segment_data_t *info, struct drm_color_lut_32 *lut);
+void create_max_lut(segment_data_t *info, struct drm_color_lut_32 *lut);
+void clear_segment_data(segment_data_t *info);
+segment_data_t *get_segment_data(int drm_fd, uint64_t blob_id);
+
/* Test version definitions */
typedef enum kms_colorop_type {
KMS_COLOROP_ENUMERATED_LUT1D,
KMS_COLOROP_CUSTOM_LUT1D,
+ KMS_COLOROP_MULTSEG_LUT1D,
KMS_COLOROP_CTM_3X4,
KMS_COLOROP_MULTIPLIER,
KMS_COLOROP_LUT3D
@@ -140,6 +153,18 @@ typedef struct kms_colorop_lut3d_info {
enum drm_colorop_lut3d_interpolation_type interpolation;
} kms_colorop_lut3d_info_t;
+typedef enum kms_colorop_multseg_lut1d_tf {
+ KMS_COLOROP_MULTSEG_LUT1D_ZERO,
+ KMS_COLOROP_MULTSEG_LUT1D_LINEAR,
+ KMS_COLOROP_MULTSEG_LUT1D_MAX,
+} kms_colorop_multseg_lut1d_tf_t;
+
+typedef struct kms_colorop_multseg_lut1d_info {
+ uint32_t lut_size;
+ kms_colorop_multseg_lut1d_tf_t lut_type;
+ struct drm_color_lut_32 *lut;
+} kms_colorop_multseg_lut1d_info_t;
+
typedef struct kms_colorop {
kms_colorop_type_t type;
@@ -147,6 +172,7 @@ typedef struct kms_colorop {
kms_colorop_enumerated_lut1d_info_t enumerated_lut1d_info;
igt_1dlut_t *lut1d;
igt_3dlut_t *lut3d;
+ kms_colorop_multseg_lut1d_info_t multseg_lut1d_info;
const igt_matrix_3x4_t *matrix_3x4;
double multiplier;
};
@@ -179,6 +205,9 @@ void igt_colorop_set_3dlut(igt_display_t *display,
igt_colorop_t *colorop,
const igt_3dlut_norm_t *lut3d,
const size_t lut_size);
+void igt_colorop_set_multseg_1dlut(igt_display_t *display,
+ igt_colorop_t *colorop,
+ const kms_colorop_multseg_lut1d_info_t custom_lut1d_info);
#define set_color_pipeline_bypass(plane) igt_plane_set_prop_enum((plane), IGT_PLANE_COLOR_PIPELINE, "Bypass")
--
2.25.1
More information about the igt-dev
mailing list