[PATCH i-g-t v2] tests/kms_plane_scaling: Skip scalar2 downscale tests on Intel Gen14+ with specific conditions

[Sharma, Swati2]

Hi Ramanaidu,

Please find my comments inline.

On 03-07-2025 07:56 pm, Naladala Ramanaidu wrote:
> Add a conditional check to skip tests involving scalar2 downscale
Typo %s/scalar2/scaler2. Please fix subject aswell.
> operations on Intel devices. This avoids running unsupported
> scenarios and helps prevent potential test failures.
>
> v2: Use break for scalar2 downscale.
>
> Bspec: 69901
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
>   tests/kms_plane_scaling.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 63d35d76b..46a65fc5b 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -1536,6 +1536,16 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   			igt_describe(scaler_with_2_planes_tests[index].describe);
>   			igt_subtest_with_dynamic(scaler_with_2_planes_tests[index].name) {
>   				for_each_pipe(&data.display, pipe) {
> +					if (is_intel_device(data.drm_fd) &&
Create a separate function for this condition.
> +					    (intel_display_ver(data.devid) >= 14) &&
> +					    ((scaler_with_2_planes_tests[index].test_type ==
> +					      TEST_PLANES_DOWNSCALE) ||
> +					    (scaler_with_2_planes_tests[index].test_type ==
> +					     TEST_PLANES_UPSCALE_DOWNSCALE)) &&
> +					    (scaler_with_2_planes_tests[index]. sf_plane1 != 1)) {
For consistency use 1.0
For this condition add comment,
plane1 : unity scaling plane2: ds => scaler1 is free, so ds can be done 
using scaler1.
> +						igt_info("Scalar2 does not support downscale operation\n");
Fix typo here as well.
Add a comment here something like
/* On Intel display version 14+, Scaler2 does not support downscaling. */
> +						break;
> +					}
>   					igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   						for_each_valid_output_on_pipe(&data.display, pipe, output) {
>   							igt_info("Trying on %s\n",