[PATCH v5,resend i-g-t 2/6] tests: Add core_debugfs
Kamil Konieczny
kamil.konieczny at linux.intel.com
Thu Jul 10 09:35:50 UTC 2025
Hi Peter,
On 2025-07-08 at 16:40:34 +0200, Peter Senna Tschudin wrote:
> Introduce core_debugfs that is expected to work with any GPU, not
> limited to i915 and Xe. The test attempts to open every file in debugfs
> associated with the GPU.
>
> Cc: lucas.demarchi at intel.com
> Cc: rodrigo.vivi at intel.com
> Cc: kamil.konieczny at linux.intel.com
> Cc: katarzyna.piecielska at intel.com
> Cc: zbigniew.kempczynski at intel.com
> Cc: michal.wajdeczko at intel.com
> Cc: karthik.b.s at intel.com
> Signed-off-by: Peter Senna Tschudin <peter.senna at linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> v5:
> - use igt_dir_process_files_simple()
> v4:
> - unchanged from v3
> v3:
> - removed "debugfs" from subtest name (Thanks Michal Wajdeczko)
> v2:
> - changed style of comparison to NULL
>
> docs/code_coverage.md | 18 ++++-----
> scripts/code_cov_selftest.sh | 2 +-
> tests/core_debugfs.c | 48 ++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 1 +
> tests/intel-ci/xe-fast-feedback.testlist | 1 +
> tests/meson.build | 1 +
> 6 files changed, 61 insertions(+), 10 deletions(-)
> create mode 100644 tests/core_debugfs.c
>
> diff --git a/docs/code_coverage.md b/docs/code_coverage.md
> index 031611e69..8c4857412 100644
> --- a/docs/code_coverage.md
> +++ b/docs/code_coverage.md
> @@ -162,23 +162,23 @@ For each script, the igt_runner passes just one parameter: the results
> directory + the test name.
>
> For instance, if it is needed to run a test called
> -`intel_sysfs_debugfs (i915-debugfs-read-all-entries)` using `code_cov_capture`
> +`core_debugfs (read-all-entries)` using `code_cov_capture`
> parameter, e. g.:
>
> ```
> -$ echo "igt at intel_sysfs_debugfs@i915-debugfs-read-all-entries" > my.testlist
> +$ echo "igt at core_debugfs@read-all-entries" > my.testlist
> $ ./scripts/run-tests.sh -T my.testlist -k ~/linux -c code_cov_capture -P
> Found test list: "/basedir/igt/build/tests/test-list.txt"
> -[31410.499969] [1/1] intel_sysfs_debugfs (i915-debugfs-read-all-entries)
> +[31410.499969] [1/1] core_debugfs (read-all-entries)
> [31411.060446] Storing code coverage results...
> -[31418.01] Code coverage wrote to /basedir/igt/results/code_cov/intel_sysfs_debugfs_i915_debugfs_read_all_entries.info
> +[31418.01] Code coverage wrote to /basedir/igt/results/code_cov/core_debugfs_debugfs_read_all_entries.info
> Done.
> ```
>
> The script will be called as:
>
> ```
> -code_cov_capture results/code_cov/intel_sysfs_debugfs_i915_debugfs_read_all_entries
> +code_cov_capture results/code_cov/core_debugfs_debugfs_read_all_entries
> ```
>
> Please notice that any character that it is not a number nor a letter at the
> @@ -376,7 +376,7 @@ OUT_DIR="${HOME}/results"
>
> mkdir -p $OUT_DIR/html
>
> -echo "igt at intel_sysfs_debugfs@i915-debugfs-read-all-entries" > $TESTLIST
> +echo "igt at core_debugfs@read-all-entries" > $TESTLIST
> echo "igt at core_auth@basic-auth" >> $TESTLIST
> echo "igt at gem_exec_basic@basic" >> $TESTLIST
>
> @@ -401,8 +401,8 @@ genhtml -q -s --legend --branch-coverage $OUT_DIR/results.info
> Running such script produces the following output:
>
> ```
> -[3622.993304] [1/3] intel_sysfs_debugfs (i915-debugfs-read-all-entries)
> -[3631.95] Code coverage wrote to results/code_cov/intel_sysfs_debugfs_i915_debugfs_read_all_entries.info
> +[3622.993304] [1/3] core_debugfs (read-all-entries)
> +[3631.95] Code coverage wrote to results/code_cov/core_debugfs_debugfs_read_all_entries.info
> [3626.217016] Storing code coverage results...
> [3631.957998] [2/3] core_auth (basic-auth)
> [3638.03] Code coverage wrote to results/code_cov/core_auth_basic_auth.info
> @@ -419,7 +419,7 @@ core_auth_basic_auth.info:
> Ignored......: non-drm headers and source files where none of its code ran.
> Source files.: 23.27% (165 of 709 total), 29.57% (165 of 558 filtered)
>
> -intel_sysfs_debugfs_i915_debugfs_read_all_entries.info:
> +core_debugfs_debugfs_read_all_entries.info:
> lines......: 19.3% (20266 of 104802 lines)
> functions..: 17.5% (1922 of 10971 functions)
> branches...: 12.7% (9462 of 74555 branches)
> diff --git a/scripts/code_cov_selftest.sh b/scripts/code_cov_selftest.sh
> index bc5ef7458..6f3a6db55 100755
> --- a/scripts/code_cov_selftest.sh
> +++ b/scripts/code_cov_selftest.sh
> @@ -13,7 +13,7 @@ if [ -z "$IGT_KERNEL_TREE" ] ; then
> exit 1
> fi
>
> -TEST="igt at intel_sysfs_debugfs@i915-debugfs-read-all-entries"
> +TEST="igt at core_debugfs@read-all-entries"
>
> TESTLIST="my_tests.testlist"
> GATHER="scripts/code_cov_gather_on_test.py"
> diff --git a/tests/core_debugfs.c b/tests/core_debugfs.c
> new file mode 100644
> index 000000000..8ce305c40
> --- /dev/null
> +++ b/tests/core_debugfs.c
> @@ -0,0 +1,48 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2025 Intel Corporation
> + */
> +
> +#include "igt.h"
> +#include "igt_debugfs.h"
> +#include "igt_dir.h"
> +
> +/**
> + * TEST: debugfs test
> + * Description: Read entries from debugfs
> + * Category: Core
> + * Mega feature: General Core features
> + * Sub-category: uapi
> + * Functionality: debugfs
> + * Feature: core
> + * Test category: uapi
> + *
> + * SUBTEST: read-all-entries
> + * Description: Read all entries from debugfs path validating debugfs entries
> + */
> +
> +IGT_TEST_DESCRIPTION("Read entries from debugfs");
> +
> +igt_main
> +{
> + int debugfs = -1;
> + int fd = -1;
> +
> + igt_fixture {
> + fd = drm_open_driver_master(DRIVER_ANY);
> + debugfs = igt_debugfs_dir(fd);
> + igt_require(debugfs >= 0);
> +
> + kmstest_set_vt_graphics_mode();
> + }
> +
> + igt_describe("Read all entries from debugfs path.");
> + igt_subtest("read-all-entries") {
> + igt_dir_process_files_simple(debugfs);
> + }
> +
> + igt_fixture {
> + close(debugfs);
> + drm_close_driver(fd);
> + }
> +}
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 82395e7ea..3ec1b95cf 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -3,6 +3,7 @@ igt at i915_module_load@load
>
> # Keep alphabetically sorted by default
> igt at core_auth@basic-auth
> +igt at core_debugfs@read-all-entries
> igt at fbdev@eof
> igt at fbdev@info
> igt at fbdev@nullptr
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index d9d180d87..ac3177ae9 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -7,6 +7,7 @@ igt at fbdev@nullptr
> igt at fbdev@read
> igt at fbdev@write
>
> +igt at core_debugfs@read-all-entries
> igt at intel_sysfs_debugfs@xe-base
> igt at intel_sysfs_debugfs@xe-debugfs-read-all-entries
> igt at intel_sysfs_debugfs@xe-forcewake
> diff --git a/tests/meson.build b/tests/meson.build
> index 9b87a0d24..99d7d95be 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -1,5 +1,6 @@
> test_progs = [
> 'core_auth',
> + 'core_debugfs',
> 'core_getclient',
> 'core_getstats',
> 'core_getversion',
> --
> 2.43.0
>
More information about the igt-dev
mailing list