[PATCH i-g-t] tests/kms_plane_cursor: Optimise plane cursor behavior on simulation

Reddy Guddati, Santhosh santhosh.reddy.guddati at intel.com
Fri Jul 11 08:10:47 UTC 2025


Hi Pranay,

On 10-07-2025 20:09, Pranay Samala wrote:
> Reduce the number of cursor positions and limit the
> execution only to a single pipe during simulation.
> 
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> ---
>   tests/kms_plane_cursor.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 1b72515f7..9ce35e045 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -237,6 +237,8 @@ static void test_cursor_spots(data_t *data, int size, unsigned int flags)
>   
>   	for (i = 0; i < ARRAY_SIZE(pos); ++i) {
>   		test_cursor_pos(data, pos[i].x, pos[i].y, flags);
> +		if (i == 2 && igt_run_in_simulation())
Please add a comment mentioning that limiting only to first 3 positions.
nit: good to reorder condition, igt_run_in_simulation() && i ==2, which 
is efficient when first condition fails , will avoid comparision.

With this fixed.
LGTM
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>> 
+			break;
>   	}
>   }
>   
> @@ -347,6 +349,8 @@ igt_main
>   						test_cursor(&data, size, tests[i].flags);
>   
>   					test_cleanup(&data);
> +					if (igt_run_in_simulation())
> +						break;
>   				}
>   
>   				test_fini(&data);



More information about the igt-dev mailing list