[PATCH i-g-t] tests/kms_vrr: Pull Panel Replay check before setting up output

[B, Jeevan]

Thanks for the review. I will change it and float the next revision.

From: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>
Sent: Monday, July 14, 2025 5:07 PM
To: B, Jeevan <jeevan.b at intel.com>; igt-dev at lists.freedesktop.org
Cc: B S, Karthik <karthik.b.s at intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_vrr: Pull Panel Replay check before setting up output


Hi Jeevan,
On 7/14/2025 3:58 PM, Jeevan B wrote:

Adding the Panel Replay support check later in the test was causing

an invalid skip, since the test disables PSR/PR in output_constraint().

Move the check earlier to ensure correct capability detection and avoid

unintended skips.



Fixes: 7da0c57182cc ("tests/kms_vrr: Skip LOBF test if PR is not supported on sink")

Signed-off-by: Jeevan B <jeevan.b at intel.com><mailto:jeevan.b at intel.com>

---

 tests/kms_vrr.c | 13 ++++++++-----

 1 file changed, 8 insertions(+), 5 deletions(-)



diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c

index 9c2c4ac92..85a90bb25 100644

--- a/tests/kms_vrr.c

+++ b/tests/kms_vrr.c

@@ -960,6 +960,14 @@ static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags

                return false;

         }



+        if (flags & TEST_LINK_OFF) {

+               if (!psr_sink_support(data->drm_fd,

+                                    data->debugfs_fd, PR_MODE, NULL)) {

+                       igt_info("LOBF not supported\n");

+                       return false;

+               }

+        }

+

Consolidate TEST_LINK_OFF condition to avoid duplicated checks.

imho, This should be as below:
if (flags & TEST_LINK_OFF) {

       igt_require_f(psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL), "LOBF not supported");

if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) || psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))

}



         if (flags & TEST_LINK_OFF) {

                if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||

                    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))

@@ -1051,11 +1059,6 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)

                               continue;

                        }



-                       if (flags == TEST_LINK_OFF)

-                        igt_require_f(psr_sink_support(data->drm_fd,

-                                            data->debugfs_fd, PR_MODE, output),

-                                            "LOBF not supported");

-

                        igt_dynamic_f("pipe-%s-%s",

                                     kmstest_pipe_name(pipe), output->name)

                               test(data, pipe, output, flags);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20250714/1097f6ac/attachment-0001.htm>