[PATCH i-g-t v3 15/41] lib/vkms: Test connector default values

[Louis Chauvet]

Le 15/07/2025 à 12:24, José Expósito a écrit :
> Add a helper to get the connector status and test that the default
> value is set when a new connector is created.
> 
> Signed-off-by: José Expósito <jose.exposito89 at gmail.com>

Reviewed-by: Louis Chauvet <louis.chauvet at bootlin.com>

> ---
>   lib/igt_vkms.c             | 33 +++++++++++++++++++++++++++++++++
>   lib/igt_vkms.h             |  3 +++
>   tests/vkms/vkms_configfs.c | 21 +++++++++++++++++++++
>   3 files changed, 57 insertions(+)
> 
> diff --git a/lib/igt_vkms.c b/lib/igt_vkms.c
> index eecad1977..c8b0dd071 100644
> --- a/lib/igt_vkms.c
> +++ b/lib/igt_vkms.c
> @@ -25,6 +25,7 @@
>   #define VKMS_FILE_ENABLED		"enabled"
>   #define VKMS_FILE_PLANE_TYPE		"type"
>   #define VKMS_FILE_CRTC_WRITEBACK	"writeback"
> +#define VKMS_FILE_CONNECTOR_STATUS	"status"
>   
>   enum vkms_pipeline_item {
>   	VKMS_PIPELINE_ITEM_PLANE,
> @@ -288,6 +289,22 @@ void igt_vkms_get_connector_path(igt_vkms_t *dev, const char *name, char *path,
>   	get_pipeline_item_path(dev, VKMS_PIPELINE_ITEM_CONNECTOR, name, path, len);
>   }
>   
> +/**
> + * igt_vkms_get_connector_status_path:
> + * @dev: Device containing the connector
> + * @name: Connector name
> + * @path: Output path
> + * @len: Maximum @path length
> + *
> + * Returns the connector "status" file path.
> + */
> +void igt_vkms_get_connector_status_path(igt_vkms_t *dev, const char *name,
> +					char *path, size_t len)
> +{
> +	get_pipeline_item_file_path(dev, VKMS_PIPELINE_ITEM_CONNECTOR, name,
> +				    VKMS_FILE_CONNECTOR_STATUS, path, len);
> +}
> +
>   /**
>    * igt_vkms_device_create:
>    * @name: VKMS device name
> @@ -581,3 +598,19 @@ void igt_vkms_device_add_connector(igt_vkms_t *dev, const char *name)
>   {
>   	add_pipeline_item(dev, VKMS_PIPELINE_ITEM_CONNECTOR, name);
>   }
> +
> +/**
> + * igt_vkms_connector_get_status:
> + * @dev: Device the connector belongs to
> + * @name: Connector name
> + *
> + * Return the connector status.
> + */
> +int igt_vkms_connector_get_status(igt_vkms_t *dev, const char *name)
> +{
> +	char path[PATH_MAX];
> +
> +	igt_vkms_get_connector_status_path(dev, name, path, sizeof(path));
> +
> +	return read_int(path);
> +}
> diff --git a/lib/igt_vkms.h b/lib/igt_vkms.h
> index 6dd576b41..3d27bfebb 100644
> --- a/lib/igt_vkms.h
> +++ b/lib/igt_vkms.h
> @@ -35,6 +35,8 @@ void igt_vkms_get_encoder_path(igt_vkms_t *dev, const char *name, char *path,
>   			       size_t len);
>   void igt_vkms_get_connector_path(igt_vkms_t *dev, const char *name, char *path,
>   				 size_t len);
> +void igt_vkms_get_connector_status_path(igt_vkms_t *dev, const char *name,
> +					char *path, size_t len);
>   
>   igt_vkms_t *igt_vkms_device_create(const char *name);
>   void igt_vkms_device_destroy(igt_vkms_t *dev);
> @@ -55,5 +57,6 @@ void igt_vkms_crtc_set_writeback_enabled(igt_vkms_t *dev, const char *name,
>   void igt_vkms_device_add_encoder(igt_vkms_t *dev, const char *name);
>   
>   void igt_vkms_device_add_connector(igt_vkms_t *dev, const char *name);
> +int igt_vkms_connector_get_status(igt_vkms_t *dev, const char *name);
>   
>   #endif /* __IGT_VKMS_H__ */
> diff --git a/tests/vkms/vkms_configfs.c b/tests/vkms/vkms_configfs.c
> index 595d258f6..d7ce4aa17 100644
> --- a/tests/vkms/vkms_configfs.c
> +++ b/tests/vkms/vkms_configfs.c
> @@ -466,6 +466,26 @@ static void test_connector_default_files(void)
>   	igt_vkms_device_destroy(dev);
>   }
>   
> +/**
> + * SUBTEST: connector-default-values
> + * Description: Check that the default values for the connector are correct.
> + */
> +
> +static void test_connector_default_values(void)
> +{
> +	igt_vkms_t *dev;
> +
> +	dev = igt_vkms_device_create(__func__);
> +	igt_assert(dev);
> +
> +	igt_vkms_device_add_connector(dev, "connector0");
> +
> +	igt_assert_eq(igt_vkms_connector_get_status(dev, "connector0"),
> +		      DRM_MODE_CONNECTED);
> +
> +	igt_vkms_device_destroy(dev);
> +}
> +
>   igt_main
>   {
>   	struct {
> @@ -485,6 +505,7 @@ igt_main
>   		{ "crtc-valid-values", test_crtc_valid_values },
>   		{ "encoder-default-files", test_encoder_default_files },
>   		{ "connector-default-files", test_connector_default_files },
> +		{ "connector-default-values", test_connector_default_values },
>   	};
>   
>   	igt_fixture {

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com