[PATCH i-g-t v1 1/3] intel-ci/meson: Use follow_symlinks only for new meson

Knop, Ryszard ryszard.knop at intel.com
Sat Jul 19 14:41:47 UTC 2025


LGTM

Reviewed-by: Ryszard Knop <ryszard.knop at intel.com>

On Fri, 2025-07-18 at 17:15 +0200, Kamil Konieczny wrote:
> After adding symlinks to our CI files I also used an option
> which makes meson to create actual symlinks at installation.
> It looks like this option was added in recent version of
> meson and brakes builds on older ones:
> 
> tests/intel-ci/meson.build:65:0: ERROR: install_data got unknown keyword arguments "follow_symlinks"
> 
> Use this option only when a new meson is present.
> 
> Suggested-by: Ryszard Knop <ryszard.knop at intel.com>
> Reported-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/intel-ci/meson.build | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel-ci/meson.build b/tests/intel-ci/meson.build
> index 60d4e0eb8..58f340b57 100644
> --- a/tests/intel-ci/meson.build
> +++ b/tests/intel-ci/meson.build
> @@ -27,4 +27,9 @@ intelci_files = [
>    'xe-sriov-vm.blocklist.txt',
>  ]
>  
> -install_data(sources : intelci_files, install_dir : datadir, follow_symlinks : false)
> +if meson.version().version_compare('<1.3.0')
> +  install_data(sources : intelci_files, install_dir : datadir)
> +else
> +  install_data(sources : intelci_files, install_dir : datadir, follow_symlinks : false)
> +endif
> +


More information about the igt-dev mailing list