[PATCH i-g-t v1 3/3] meson: Fix warning

Peter Senna Tschudin peter.senna at linux.intel.com
Mon Jul 21 10:15:28 UTC 2025



On 7/18/2025 5:15 PM, Kamil Konieczny wrote:
> There is now warning printed by meson:
> 
> WARNING: You should add the boolean check kwarg to the run_command call.
> 
> As after the run_command there is an explicit check for error,
> just inform meson to not make a check itself.
> 
> Cc: Jani Nikula <jani.nikula at intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
Reviewed-by: Peter Senna Tschudin <peter.senna at linux.intel.com>

> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 4efad72cf..aeed3b1d2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -171,8 +171,8 @@ xmlrpc_client = dependency('xmlrpc_client', required : false)
>  
>  xmlrpc_cmd = find_program('xmlrpc-c-config', required : false)
>  if not xmlrpc.found() and xmlrpc_cmd.found()
> -	libs_cmd = run_command(xmlrpc_cmd, 'client', '--libs')
> -	cflags_cmd = run_command(xmlrpc_cmd, 'client', '--cflags')
> +	libs_cmd = run_command(xmlrpc_cmd, 'client', '--libs', check: false)
> +	cflags_cmd = run_command(xmlrpc_cmd, 'client', '--cflags', check: false)
>  
>  	if libs_cmd.returncode() == 0 and cflags_cmd.returncode() == 0
>  		xmlrpc = declare_dependency(compile_args: cflags_cmd.stdout().strip().split(),



More information about the igt-dev mailing list