[PATCH v4 i-g-t 3/3] lib/tests: Update hook unit testing

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Jul 23 16:58:23 UTC 2025


Hi Peter,
On 2025-07-23 at 12:44:06 +0200, Peter Senna Tschudin wrote:
> The unit testing for hooks checks env vars created by the hooks
> infrastructure.  Update unit testing to account for the new
> IGT_HOOK_KMOD_UNBIND_MODULE_NAME env var.
> 
> Cc: Gustavo Sousa <gustavo.sousa at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Signed-off-by: Peter Senna Tschudin <peter.senna at linux.intel.com>

Thank you for fixint it, now it works.

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
> v4:
>  - Introduced in v4
> 
>  lib/tests/igt_hook.c             | 1 +
>  lib/tests/igt_hook_integration.c | 9 +++++----
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/tests/igt_hook.c b/lib/tests/igt_hook.c
> index 676c6eb7a..420a19c72 100644
> --- a/lib/tests/igt_hook.c
> +++ b/lib/tests/igt_hook.c
> @@ -16,6 +16,7 @@ static const char *env_var_names[] = {
>  	"IGT_HOOK_TEST",
>  	"IGT_HOOK_SUBTEST",
>  	"IGT_HOOK_DYN_SUBTEST",
> +	"IGT_HOOK_KMOD_UNBIND_MODULE_NAME",
>  	"IGT_HOOK_RESULT",
>  };
>  
> diff --git a/lib/tests/igt_hook_integration.c b/lib/tests/igt_hook_integration.c
> index 8525c6a3f..3b35065ab 100644
> --- a/lib/tests/igt_hook_integration.c
> +++ b/lib/tests/igt_hook_integration.c
> @@ -16,24 +16,25 @@ char fake_argv_buffer[1024];
>  char *fake_argv[64];
>  int fake_argc;
>  
> -#define ENV_ARRAY(evt_name, fullname_suffix, subtest, dyn_subtest, result) \
> +#define ENV_ARRAY(evt_name, fullname_suffix, subtest, dyn_subtest, unbind_module_name, result) \
>  { \
>  	"IGT_HOOK_EVENT=" evt_name, \
>  	"IGT_HOOK_TEST_FULLNAME=igt at igt_hook_integration" fullname_suffix, \
>  	"IGT_HOOK_TEST=igt_hook_integration", \
>  	"IGT_HOOK_SUBTEST=" subtest, \
>  	"IGT_HOOK_DYN_SUBTEST=" dyn_subtest, \
> +	"IGT_HOOK_KMOD_UNBIND_MODULE_NAME=" unbind_module_name, \
>  	"IGT_HOOK_RESULT=" result, \
>  }
>  
>  #define TEST_ENV(evt_name, result) \
> -	ENV_ARRAY(evt_name, "", "", "", result)
> +	ENV_ARRAY(evt_name, "", "", "", "", result)
>  
>  #define SUBTEST_ENV(evt_name, subtest, result) \
> -	ENV_ARRAY(evt_name, "@" subtest, subtest, "", result)
> +	ENV_ARRAY(evt_name, "@" subtest, subtest, "", "", result)
>  
>  #define DYN_SUBTEST_ENV(evt_name, subtest, dyn_subtest, result) \
> -	ENV_ARRAY(evt_name, "@" subtest "@" dyn_subtest, subtest, dyn_subtest, result)
> +	ENV_ARRAY(evt_name, "@" subtest "@" dyn_subtest, subtest, dyn_subtest, "", result)
>  
>  const char *pre_test_env[] = TEST_ENV("pre-test", "");
>  const char *pre_subtest_a_env[] = SUBTEST_ENV("pre-subtest", "a", "");
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list