[PATCH v2 i-g-t] tests/kms_debugfs: Use static var for display

Peter Senna Tschudin peter.senna at linux.intel.com
Thu Jul 24 12:27:10 UTC 2025


Commit ebe65a923a2b ("tests: Add kms_debugfs") introduced a new test.
Unfortunately, that commit used dynamic allocation for `display` and
missed a call to free(display) during cleanup. Use a stack variable
instead, eliminating the need for dynamic memory management.

Fixes: ebe65a923a2b ("tests: Add kms_debugfs")
Cc: Karthik B S <karthik.b.s at intel.com>
Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
Signed-off-by: Peter Senna Tschudin <peter.senna at linux.intel.com>
---
 tests/kms_debugfs.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/tests/kms_debugfs.c b/tests/kms_debugfs.c
index 75ef15353..570ad1c0c 100644
--- a/tests/kms_debugfs.c
+++ b/tests/kms_debugfs.c
@@ -97,7 +97,7 @@ IGT_TEST_DESCRIPTION("Read entries from debugfs with display on/off.");
 igt_main
 {
 	int debugfs = -1;
-	igt_display_t *display;
+	igt_display_t display;
 	int fd = -1;
 
 	igt_fixture {
@@ -107,28 +107,27 @@ igt_main
 
 		kmstest_set_vt_graphics_mode();
 
-		display = calloc(1, sizeof(*display));
-		igt_display_require(display, fd);
+		igt_display_require(&display, fd);
 
 		/* Make sure we have at least one output connected */
-		igt_display_require_output(display);
+		igt_display_require_output(&display);
 	}
 
 	igt_subtest("display-off-read-all") {
-		igt_display_all_off(display);
+		igt_display_all_off(&display);
 
 		igt_dir_process_files_simple(debugfs);
 	}
 
 	igt_subtest("display-on-read-all") {
 		/* try to light all pipes */
-		igt_display_all_on(display);
+		igt_display_all_on(&display);
 
 		igt_dir_process_files_simple(debugfs);
 	}
 
 	igt_fixture {
-		igt_display_fini(display);
+		igt_display_fini(&display);
 		close(debugfs);
 		drm_close_driver(fd);
 	}
-- 
2.43.0



More information about the igt-dev mailing list