[PATCH i-g-t v2 1/4] tests/intel/xe_pmu: Validate engine activity on gt reset and suspend

[Riana Tauro]

Hi Umesh

On 5/29/2025 11:08 PM, Umesh Nerlige Ramappa wrote:
> On Thu, May 29, 2025 at 12:23:56PM +0530, Riana Tauro wrote:
>> Add tests to validate engine activity before and after gt resets
>> and suspend
>>
>> Signed-off-by: Riana Tauro <riana.tauro at intel.com>
>> ---
>> tests/intel/xe_pmu.c | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
>> index 02f23bd7d..15b4b82d8 100644
>> --- a/tests/intel/xe_pmu.c
>> +++ b/tests/intel/xe_pmu.c
>> @@ -40,6 +40,12 @@
>>  * Description: Test to validate engine activity by running workload 
>> on all engines
>>  *        simultaneously and trailing idle
>>  *
>> + * SUBTEST: engine-activity-gt-reset
>> + * Description: Test to validate engine activity on all engines 
>> before and after gt reset
>> + *
>> + * SUBTEST: engine-activity-suspend
>> + * Description: Test to validate engine activity on all engines 
>> before and after s2idle
>> + *
>>  * SUBTEST: engine-activity-most-load
>>  * Description: Test to validate engine activity by running workload 
>> on all engines except one
>>  *
>> @@ -812,6 +818,21 @@ igt_main
>>     igt_subtest("engine-activity-all-load-idle")
>>         engine_activity_load_all(fd, num_engines, TEST_LOAD | 
>> TEST_TRAILING_IDLE);
>>
>> +    igt_describe("Validate engine activity before and after gt reset");
>> +    igt_subtest("engine-activity-gt-reset") {
>> +        engine_activity_load_all(fd, num_engines, TEST_LOAD);
>> +        xe_for_each_gt(fd, gt)
>> +            xe_force_gt_reset_sync(fd, gt);
>> +        engine_activity_load_all(fd, num_engines, TEST_LOAD);
> 
> This is also probably one of the tests that we want to run, but for gt 
> reset and effect on PMU, I would just do the reset withing the single
> engine activity test in the same manner as it was in i915.


i915 test checks for idle after gt-reset. Since engine activity is 
registered with GuC.  I wanted to check if running a spinner again after 
gt-reset and capturing activity values works

Should i add another test for idle after gt reset?

Thanks
Riana

  >
>> +    }
>> +
>> +    igt_describe("Validate engine activity before and after s2idle");
>> +    igt_subtest("engine-activity-suspend") {
>> +        engine_activity_load_all(fd, num_engines, TEST_LOAD);
>> +        igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE, 
>> SUSPEND_TEST_NONE);
>> +        engine_activity_load_all(fd, num_engines, TEST_LOAD);
>> +    }
>> +
>>     igt_subtest_group {
>>         unsigned int num_fns;
>>
>> -- 
>> 2.47.1
>>