[PATCH i-g-t] xe-perf-record: use correct sysctl suggestion.

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Jun 3 15:02:16 UTC 2025


Hi Bram,
On 2025-06-02 at 19:55:46 -0700, Bram Stolk wrote:
> From e03269c796207749afe2f7d49ac64b672e7185af Mon Sep 17 00:00:00 2001
> From: Bram Stolk <b.stolk at gmail.com>
> Date: Sat, 31 May 2025 11:40:18 -0700
> Subject: [PATCH i-g-t] xe-perf-record: use correct sysctl suggestion.

imho subject
[PATCH i-g-t] xe-perf-record: use correct sysctl suggestion.

would be better with:
[PATCH i-g-t] tools/xe-perf/xe-perf-record: Fix printing sysctl suggestion

This could be done at merge, no need for resend.

> 
> On xe, perf_stream_paranoid is not used.
> Instead, observation_paranoid should be used.
> 

+cc Ashutosh Dixit <ashutosh.dixit at intel.com>

> Signed-off-by: Bram Stolk <b.stolk at gmail.com>
> ---
>  tools/xe-perf/xe_perf_recorder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/xe-perf/xe_perf_recorder.c
> b/tools/xe-perf/xe_perf_recorder.c
> index 9cf51f3e1..5bd91aeb1 100644
> --- a/tools/xe-perf/xe_perf_recorder.c
> +++ b/tools/xe-perf/xe_perf_recorder.c
> @@ -1137,7 +1137,7 @@ main(int argc, char *argv[])
>   if (ctx.metric_set->perf_oa_metrics_set == 0) {
>   fprintf(stderr,
>   "Unable to load performance configuration, consider running:\n"
> - "   sysctl dev.xe.perf_stream_paranoid=0\n");
> + "   sysctl dev.xe.observation_paranoid=0\n");

I needed to tweak a little so this will apply. Besides looks ok,

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Thank you for contribution,

Regards,
Kamil

>   goto fail;
>   }
> 
> -- 
> 2.48.1


More information about the igt-dev mailing list