[PATCH i-g-t v14 03/11] include/android: Add stub for procps and glib

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Jun 4 12:51:14 UTC 2025


Hi Jeevaka,
On 2025-06-03 at 19:23:46 +0000, Jeevaka Prabu Badrappan wrote:
> From: Sapna Singh <sapna1.singh at intel.com>
> 
> As procps, glib are not available in Android, not able to build igt
> for Android.
> 
> Provided stub implementations so igt can be compiled for both Android
> and linux from same code base. In case of linux systems, system
> libraries will be used whereas for Android stubs will be used with
> reduced test coverage.
> 
> Signed-off-by: Sapna Singh <sapna1.singh at intel.com>
> Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan at intel.com>
> ---
>  include/android/glib.h   | 44 ++++++++++++++++++++++++++++++++++++++++
>  include/android/procps.h | 40 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 84 insertions(+)
>  create mode 100644 include/android/glib.h
>  create mode 100644 include/android/procps.h
> 
> diff --git a/include/android/glib.h b/include/android/glib.h
> new file mode 100644
> index 000000000..c80a16e47
> --- /dev/null
> +++ b/include/android/glib.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: MIT */
> +
> +#ifndef _IGT_ANDROID_GLIB_H
> +#define _IGT_ANDROID_GLIB_H
> +
> +#include <stdbool.h>
> +#include <stdlib.h>
> +
> +#define G_KEY_FILE_NONE 0
> +#define G_REGEX_OPTIMIZE 0
> +
> +typedef struct _GError {
> +	int code;
> +	char *message;
> +} GError;
> +
> +typedef struct _GKeyFile {
> +	char *key;
> +	char *value;
> +} GKeyFile;
> +
> +typedef int gint;
> +typedef size_t gsize;
> +typedef char gchar;
> +typedef unsigned char guchar;
> +typedef void GRegex;
> +
> +static inline void g_clear_error(GError **error) { }
> +static inline void g_error_free(GError *error) { }

Please add newline here, so it will separate different
functionality.

> +static inline const char *g_get_home_dir(void) { return "/data/local/tmp/igt"; }

Add newline.

> +static inline void g_key_file_free(GKeyFile *file) { }
> +static inline GKeyFile *g_key_file_new(void) { return NULL; }
> +static inline int g_key_file_get_integer(GKeyFile *key_file,
> +	const char *group_name, const char *key, GError **error) { return 0; }
> +static inline char *g_key_file_get_string(GKeyFile *key_file,
> +	const char *group_name, const char *key, GError **error) { return NULL; }
> +static inline bool g_key_file_load_from_file(GKeyFile *key_file,
> +	const char *file, int flags, GError **error) { return false; }

Add newline.

Regex part is missing g_regex_match(), please add it.

imho in our GitLab we could try to add at least compilation
checks, using debian image without glib and libproc.

+cc Ryszard Knop and Petri Latvala

> +static inline GRegex *g_regex_new(const char *pattern, int compile_options,
> +	int match_options, GError **error) { return NULL; }
> +static inline void g_regex_unref(GRegex *pattern) { };

Add newline.

Regards,
Kamil

> +static gchar *g_base64_encode(const guchar *data, gsize len) { return NULL; }
> +
> +#endif /* _IGT_ANDROID_GLIB_H */
> diff --git a/include/android/procps.h b/include/android/procps.h
> new file mode 100644
> index 000000000..f859dffe1
> --- /dev/null
> +++ b/include/android/procps.h
> @@ -0,0 +1,40 @@
> +/* SPDX-License-Identifier: MIT */
> +
> +#ifndef _IGT_ANDROID_PROCPS_H
> +#define _IGT_ANDROID_PROCPS_H
> +
> +enum pids_item {
> +	PIDS_NOT_IMPLEMENTED = 0,
> +};
> +
> +enum pids_fetch_type {
> +	PIDS_FETCH_TASKS_ONLY,
> +	PIDS_FETCH_THREADS_TOO
> +};
> +
> +struct pids_result {
> +	enum pids_item item;
> +	union {
> +		unsigned long long ull_int;
> +		double real;
> +	} result;
> +};
> +
> +struct pids_stack {
> +	struct pids_result *head;
> +};
> +
> +struct pids_info;
> +
> +#define PIDS_VAL(relative_enum, type, stack, info) \
> +	((info & 0) | (stack)->head[relative_enum].result.type)
> +
> +int procps_pids_new(struct pids_info **info, enum pids_item *items, int numitems) { return 0; }
> +int procps_pids_unref(struct pids_info **info) { return 0; }
> +
> +struct pids_stack *procps_pids_get(struct pids_info *info, enum pids_fetch_type which)
> +{
> +	return NULL;
> +}
> +
> +#endif /* _IGT_ANDROID_PROCPS_H */
> -- 
> 2.49.0
> 


More information about the igt-dev mailing list