[PATCH v4 1/2] tests/intel/xe_fault_injection: Make pci_slot const
Kamil Konieczny
kamil.konieczny at linux.intel.com
Tue Jun 10 10:54:16 UTC 2025
Hi Jonathan,
On 2025-06-06 at 18:35:18 +0000, Jonathan Cavitt wrote:
> The pci_slot string is passed to multiple functions in
> xe_fault_injection. It is also unmodified in those functions, so should
Fold line at 65 column, this could be changed at merge.
> be passed as a const.
>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> Suggested-by: John Harrison <john.c.harrison at intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> tests/intel/xe_fault_injection.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
> index 9fe6bfe351..7a14ad1729 100644
> --- a/tests/intel/xe_fault_injection.c
> +++ b/tests/intel/xe_fault_injection.c
> @@ -228,7 +228,7 @@ static void set_retval(const char function_name[], long long retval)
> * @xe_wopcm_init: xe_wopcm_init
> */
> static int
> -inject_fault_probe(int fd, char pci_slot[], const char function_name[])
> +inject_fault_probe(int fd, const char pci_slot[], const char function_name[])
> {
> int err = 0;
> igt_info("Injecting error \"%s\" (%d) in function \"%s\"\n",
> @@ -255,7 +255,7 @@ inject_fault_probe(int fd, char pci_slot[], const char function_name[])
> * @xe_guc_mmio_send_recv: Inject an error when calling xe_guc_mmio_send_recv
> * @xe_guc_ct_send_recv: Inject an error when calling xe_guc_ct_send_recv
> */
> -static void probe_fail_guc(int fd, char pci_slot[], const char function_name[],
> +static void probe_fail_guc(int fd, const char pci_slot[], const char function_name[],
> struct fault_injection_params *fault_params)
> {
> int iter_start = 0, iter_end = 0, iter = 0;
> --
> 2.43.0
>
More information about the igt-dev
mailing list