[PATCH v5 0/2] tests/intel/xe_fault_injection: Ignore all errors while injecting fault

[Jonathan Cavitt]

Currently, numerous fault messages have been included in the dmesg
ignore list, and this list continues to expand.  Each time a new fault
injection point is introduced or a new feature is activated, additional
fault messages appear, making it cumbersome to manage the dmesg ignore
list.

However, we can safely assert that all dmesg reports that contain
*ERROR* in their message can be ignored, so add them to the dmesg ignore
list.  This unfortunately does not include the device probe error
itself, so that must be added separately.

While we're here, we should also assert that any errors we see are only
coming from the target PCI device.  We can do this by passing the
pci_slot name to the dmesg ignore list, which is generated during test
initialization.  In order to pass this information, all test functions
need to take the pci_slot name as a parameter.

Some functions already take the pci_slot name as a parameter but should
be modified to make the pci_slot parameter a const variable.

v2:
- Only ignore error-level dmesg reports (or, at least, reports with
  *ERROR* in them), and device probe failues
- Add PCI data to regex (Michal)

v3: (Michal)
- Revert name change
- Add change log
- Remove fixes tag from commit
- Rename ignore_faults_in_dmesg to igt_ignore_dmesg_errors_from_dut, and
  move to lib/igt_core.c
- Minor code fixes

v4:
- Return ignore_faults_in_dmesg to tests/intel/xe_fault_injection.c, but
  keep it renamed to ignore_dmesg_errors_from_dut (Kamil)

v5:
- Pass preexisting pci name instead of attempting to regenerate it on
  each run of ignore_dmesg_errors_from_dut (Daniele)
- Make pci_slot a const parameter (John)

v6:
- Minor wording fixups (Daniele, Kamil)

Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
Suggested-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: John Harrison <john.c.harrison at intel.com>
Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Jonathan Cavitt (1):
  tests/intel/xe_fault_injection: Make pci_slot const

Satyanarayana K V P (1):
  tests/intel/xe_fault_injection: Ignore all errors while injecting
    fault

 tests/intel/xe_fault_injection.c | 64 +++++++++++++++-----------------
 1 file changed, 29 insertions(+), 35 deletions(-)

-- 
2.43.0