[PATCH i-g-t] include/android: Define gboolean as bool to resolve Android build error
Kamil Konieczny
kamil.konieczny at linux.intel.com
Thu Jun 12 18:00:40 UTC 2025
Hi Jeevaka,
On 2025-06-12 at 14:38:19 +0000, Jeevaka Prabu Badrappan wrote:
> The function g_regex_match returns a gboolean, which is not defined in
> the Android environment, leading to build failure. This commit
imho first sentence is enough. You do not need to translate
C code into english.
> addresses the issue by typedef-ing gboolean to bool in the
> Android-specific GLib header file.
>
> Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan at intel.com>
> ---
> include/android/glib.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/android/glib.h b/include/android/glib.h
> index 8540d3514..e12aaeebb 100644
> --- a/include/android/glib.h
> +++ b/include/android/glib.h
> @@ -29,6 +29,7 @@ typedef char gchar;
> typedef unsigned char guchar;
> typedef void GRegex;
> typedef int GRegexMatchFlags;
> +typedef bool gboolean;
How did you missed it? Was it lost with too many errors/warnings?
Thats why I asked for container or container recipe for
independent building. The best way would be to add it to our
GitLab pipeline.
Mark, could you help us with this? Or redirect to someone from
your team?
Change LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
>
> static inline void g_clear_error(GError **error) { }
> static inline void g_error_free(GError *error) { }
> --
> 2.49.0
>
More information about the igt-dev
mailing list