[PATCH i-g-t 1/2] drm-uapi/xe: Sync with OAM uapi updates

Umesh Nerlige Ramappa umesh.nerlige.ramappa at intel.com
Mon Jun 16 17:48:45 UTC 2025


On Fri, Jun 13, 2025 at 06:08:26PM -0700, Ashutosh Dixit wrote:
>Align with kernel commit TBD ("drm/xe/oa/uapi: Expose media OA units").

but this pulls in pxp comments too. If that's intentional, you could 
just edit commit message to make it generic drm sync.

Irrespective, LGTM

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Thanks,
Umesh
>
>This commit will be replaced by the actual commit for OAM uapi changes
>after OAM kernel changes are merged.
>
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
>---
> include/drm-uapi/xe_drm.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
>index c90fab1b00..a52f955936 100644
>--- a/include/drm-uapi/xe_drm.h
>+++ b/include/drm-uapi/xe_drm.h
>@@ -1210,6 +1210,11 @@ struct drm_xe_vm_bind {
>  *    there is no need to explicitly set that. When a queue of type
>  *    %DRM_XE_PXP_TYPE_HWDRM is created, the PXP default HWDRM session
>  *    (%XE_PXP_HWDRM_DEFAULT_SESSION) will be started, if isn't already running.
>+ *    The user is expected to query the PXP status via the query ioctl (see
>+ *    %DRM_XE_DEVICE_QUERY_PXP_STATUS) and to wait for PXP to be ready before
>+ *    attempting to create a queue with this property. When a queue is created
>+ *    before PXP is ready, the ioctl will return -EBUSY if init is still in
>+ *    progress or -EIO if init failed.
>  *    Given that going into a power-saving state kills PXP HWDRM sessions,
>  *    runtime PM will be blocked while queues of this type are alive.
>  *    All PXP queues will be killed if a PXP invalidation event occurs.
>@@ -1612,6 +1617,9 @@ enum drm_xe_oa_unit_type {
>
> 	/** @DRM_XE_OA_UNIT_TYPE_OAM: OAM OA unit */
> 	DRM_XE_OA_UNIT_TYPE_OAM,
>+
>+	/** @DRM_XE_OA_UNIT_TYPE_OAM_SAG: OAM_SAG OA unit */
>+	DRM_XE_OA_UNIT_TYPE_OAM_SAG,
> };
>
> /**
>@@ -1633,6 +1641,7 @@ struct drm_xe_oa_unit {
> #define DRM_XE_OA_CAPS_SYNCS		(1 << 1)
> #define DRM_XE_OA_CAPS_OA_BUFFER_SIZE	(1 << 2)
> #define DRM_XE_OA_CAPS_WAIT_NUM_REPORTS	(1 << 3)
>+#define DRM_XE_OA_CAPS_OAM		(1 << 4)
>
> 	/** @oa_timestamp_freq: OA timestamp freq */
> 	__u64 oa_timestamp_freq;
>-- 
>2.48.1
>


More information about the igt-dev mailing list