[PATCH i-g-t v3 2/5] tests/kms_flip: Modify check_state to return true on unexpected sequence
Karthik B S
karthik.b.s at intel.com
Tue Jun 17 03:43:29 UTC 2025
Hi,
I feel it would be better to combine this with patch 4 of the series as
that justifies changing the return from 'false' to 'true'
Thanks,
Karthik.B.S
On 6/16/2025 12:08 PM, Naladala Ramanaidu wrote:
> Ensure function execution continues despite unexpected sequences
> or timestamps due to shorter frame times in higher refresh rate
> panels.
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
> tests/kms_flip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index ca31ef7dd..2328259ba 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -706,7 +706,7 @@ static bool check_state(const struct test_output *o, const struct event_state *e
> es->current_seq - (es->last_seq + o->seq_step) > 1UL << 23) {
> igt_debug("unexpected %s seq %u, should be >= %u\n",
> es->name, es->current_seq, es->last_seq + o->seq_step);
> - return false;
> + return true;
> }
>
> if (o->flags & TEST_CHECK_TS) {
> @@ -736,7 +736,7 @@ static bool check_state(const struct test_output *o, const struct event_state *e
> es->name, es->current_seq,
> es->last_seq + o->seq_step);
>
> - return false;
> + return true;
> }
> }
>
More information about the igt-dev
mailing list