[PATCH] README.md: Update oneliner build command

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Jun 23 09:59:08 UTC 2025


Hi Gustavo,
On 2025-06-19 at 09:43:46 -0300, Gustavo Sousa wrote:
> Quoting Alex Hung (2025-06-18 20:02:57-03:00)
> >This fixes the following warning:
> >
> >WARNING: Running the setup command as `meson [options]` instead of
> >`meson setup [options]` is ambiguous and deprecated.

Good catch! Thank you for fixing this.

> >
> >Signed-off-by: Alex Hung <alex.hung at amd.com>
> 
> Looks good, so
> 
> Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>
> 
> That said, perhaps we could take this opportunity to fix other
> occurrences as well? There is another one in README.md and others in
> .gitlab-ci.yml and meson.sh.

as for .gitlab-ci.yml it is already fixed with commit f6913a8b86b3
Author: Andrzej Hajda <andrzej.hajda at intel.com>
Date:   Fri Jun 13 16:30:49 2025 +0200

    gitlab-ci: correct meson setup commands

meson.sh was also fixed some time ago.

Thank you for review, I will merge it soon.

Regards,
Kamil

> 
> Quickly doing a git log on meson's manpage file, the setup command is
> available since at least 2017[1]. So perhaps updating .gitlab-ci.yml to
> use the "setup" should be fine?
> 
> [1] https://github.com/mesonbuild/meson/commit/d82c7e3c23ce6f3b0b68aea034c3f9d4d7b68935
> 
> --
> Gustavo Sousa
> 
> >---
> > README.md | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/README.md b/README.md
> >index 9cef60d88..ed6647726 100644
> >--- a/README.md
> >+++ b/README.md
> >@@ -37,7 +37,7 @@ Building
> > 
> > Oneliner to get started:
> > 
> >-    $ meson build && ninja -C build
> >+    $ meson setup build && ninja -C build
> > 
> > Note that meson insist on separate build directories from the source tree.
> > 
> >-- 
> >2.43.0
> >


More information about the igt-dev mailing list