[i-g-t,v5,1/2] tests/kms_flip: Default to tiled modifiers for stable flips on high refresh panels

[Murthy, Arun R]

On 20-06-2025 01:35, Naladala Ramanaidu wrote:
> Using tiled modifiers as the default significantly improves flip
> test pass rates, especially on high refresh rate panels.
>
> Consolidated report on 10 samples on each pipe as below.
>      - PipeA:  95.01% -> 100.00% (Improved by 4.99%)
>      - PipeB:  91.57% -> 100.00% (Improved by 8.43%)
>      - PipeC:  73.17% -> 97.94% (Improved by 24.77%)
>      - PipeD:  76.64% -> 98.89% (Improved by 22.25%)
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> Reviewed-by: Karthik B S <karthik.b.s at intel.com>
> ---

Reviewed-by: Arun R Murthy

Thanks and Regards,
Arun R Murthy
-------------------

>   tests/kms_flip.c | 13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 65016c66d..ca31ef7dd 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -282,6 +282,8 @@ static drmModeConnector *last_connector;
>   
>   uint32_t *fb_ptr;
>   
> +static igt_display_t display;
> +
>   struct type_name {
>   	int type;
>   	const char *name;
> @@ -1533,7 +1535,15 @@ restart:
>   	if (o->flags & TEST_PAN)
>   		o->fb_width *= 2;
>   
> -	modifier = DRM_FORMAT_MOD_LINEAR;
> +	if (igt_display_has_format_mod(&display, DRM_FORMAT_XRGB8888,
> +				       I915_FORMAT_MOD_4_TILED))
> +		modifier = I915_FORMAT_MOD_4_TILED;
> +	else if (igt_display_has_format_mod(&display, DRM_FORMAT_XRGB8888,
> +					    I915_FORMAT_MOD_X_TILED))
> +		modifier = I915_FORMAT_MOD_X_TILED;
> +	else
> +		modifier = DRM_FORMAT_MOD_LINEAR;
> +
>   	if (o->flags & TEST_FENCE_STRESS)
>   		modifier = I915_FORMAT_MOD_X_TILED;
>   
> @@ -2034,7 +2044,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>   		{ 0, TEST_BO_TOOBIG | TEST_NO_2X_OUTPUT, "bo-too-big" },
>   		{ 10, TEST_FLIP | TEST_SUSPEND, "flip-vs-suspend" },
>   	};
> -	igt_display_t display;
>   	int i;
>   
>   	igt_fixture {