[PATCH i-g-t v15 4/5] tests/kms_async_flips: Remove allow_fail flag from async flip tests

Karthik B S karthik.b.s at intel.com
Thu Jun 26 08:45:04 UTC 2025


On 6/23/2025 4:39 PM, Santhosh Reddy Guddati wrote:
> Remove allow_fail flag as the async supported format modifiers are
> now known to the user space. The test now executes for all supported
> format modifiers.
>
> V2: Remove check for frame 1, as no longer needed now as valid
>      modifiers are being in use. (Chaitanya)
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>
Reviewed-by: Karthik B S <karthik.b.s at intel.com>
> ---
>   tests/kms_async_flips.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 496d1c2c8..e176b2a28 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -136,7 +136,6 @@ typedef struct {
>   	enum pipe pipe;
>   	bool alternate_sync_async;
>   	bool suspend_resume;
> -	bool allow_fail;
>   	struct buf_ops *bops;
>   	bool atomic_path;
>   	bool overlay_path;
> @@ -435,7 +434,7 @@ static void test_async_flip(data_t *data)
>   		 * configuration. Therefore allow EINVAL failure and skip the
>   		 * test for AMD devices.
>   		 */
> -		if ((frame == 1 && data->allow_fail) || is_amdgpu_device(data->drm_fd))
> +		if (is_amdgpu_device(data->drm_fd))
>   			igt_skip_on(ret == -EINVAL);
>   		else
>   			igt_assert_eq(ret, 0);
> @@ -815,12 +814,6 @@ static void run_test(data_t *data, void (*test)(data_t *))
>   			continue;
>   
>   		test_init(data);
> -
> -		if (data->linear_modifier && is_intel_device(data->drm_fd))
> -			data->allow_fail = true;
> -		else
> -			data->allow_fail = false;
> -
>   		data->modifier = data->linear_modifier ? DRM_FORMAT_MOD_LINEAR : default_modifier(data);
>   
>   		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {


More information about the igt-dev mailing list