[PATCH i-g-t] lib/pciids: Sync pciid's with kernel commit 9b779ff

[Joshi, Kunal1]

Hello Kamil,

On 23-06-2025 23:30, Kamil Konieczny wrote:
> Hi Kunal,
> On 2025-06-23 at 19:02:57 +0530, Kunal Joshi wrote:
>
> few nits about this for future, as this was merged already.
>
> imho subject could be short, instead of:
>
> [PATCH i-g-t] lib/pciids: Sync pciid's with kernel commit 9b779ff
>
> simple one:
> [PATCH i-g-t] lib/pciids: Sync with kernel
>
> or little more explanatory when only few changed:
>
> [PATCH i-g-t] lib/pciids: Update BMG and PTL pci ids
>
> Reason for this short subject is that you will write details
> in patch description.
>
>> From: Shekhar Chauhan <shekhar.chauhan at intel.com>
> imho this should be your 'From:' as you are porting this
> into IGT, especially when there will be more changes
> from different authors.
>
>> As per updated Bspec, Sync PCI IDs
>>
>> Sync with the following kernel commits:
>> 9b779ff ("drm/xe/xe2_hpg: Add PCI IDs for xe2_hpg")
>> 49c6dc7 ("drm/xe/ptl: Update the PTL pci id table")
> Please use more chars for SHA1 sum, at least 12 for now, as
> suggested by checkpatch.pl script from Linux kernel source.
>
>> v1: Sync with kernel commit (Jani/Tejas)
>> v2: Specify both kernel commits in subject (Tejas)
>>
>> Cc: Jani Nikula <jani.nikula at intel.com>
>> Cc: Tejas Upadhyay <tejas.upadhyay at intel.com>
>> Signed-off-by: Shekhar Chauhan <shekhar.chauhan at intel.com>
>> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane at intel.com>
>> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
>> Signed-off-by: Matt Atwood <matthew.s.atwood at intel.com>
> Where is your s-o-b?
>
>> Link: https://lore.kernel.org/r/20250605190804.1287289-2-dnyaneshwar.bhadane@intel.com
>> Link: https://lore.kernel.org/r/20250520195749.371748-1-matthew.s.atwood@intel.com
> Nice, thank you for providing links to lore.
>
> Regards,
> Kamil
Thanks for feedback even after merge,
Have noted all the points will take care from next time.

Thanks and Regards
Kunal Joshi
>> Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
>> ---
>>   lib/pciids.h | 11 +++++++++--
>>   1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/pciids.h b/lib/pciids.h
>> index d212848d0..129c3172a 100644
>> --- a/lib/pciids.h
>> +++ b/lib/pciids.h
>> @@ -852,8 +852,11 @@
>>   	MACRO__(0xE210, ## __VA_ARGS__), \
>>   	MACRO__(0xE211, ## __VA_ARGS__), \
>>   	MACRO__(0xE212, ## __VA_ARGS__), \
>> -	MACRO__(0xE215, ## __VA_ARGS__), \
>> -	MACRO__(0xE216, ## __VA_ARGS__)
>> +	MACRO__(0xE216, ## __VA_ARGS__), \
>> +	MACRO__(0xE220, ## __VA_ARGS__), \
>> +	MACRO__(0xE221, ## __VA_ARGS__), \
>> +	MACRO__(0xE222, ## __VA_ARGS__), \
>> +	MACRO__(0xE223, ## __VA_ARGS__)
>>   
>>   /* PTL */
>>   #define INTEL_PTL_IDS(MACRO__, ...) \
>> @@ -861,6 +864,10 @@
>>   	MACRO__(0xB081, ## __VA_ARGS__), \
>>   	MACRO__(0xB082, ## __VA_ARGS__), \
>>   	MACRO__(0xB083, ## __VA_ARGS__), \
>> +	MACRO__(0xB084, ## __VA_ARGS__), \
>> +	MACRO__(0xB085, ## __VA_ARGS__), \
>> +	MACRO__(0xB086, ## __VA_ARGS__), \
>> +	MACRO__(0xB087, ## __VA_ARGS__), \
>>   	MACRO__(0xB08F, ## __VA_ARGS__), \
>>   	MACRO__(0xB090, ## __VA_ARGS__), \
>>   	MACRO__(0xB0A0, ## __VA_ARGS__), \
>> -- 
>> 2.25.1
>>