[PATCH 3/5] tests/intel/kms_link_training: extend test for eDP connector

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Kunal Joshi
> Sent: Wednesday, June 25, 2025 6:04 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Joshi, Kunal1 <kunal1.joshi at intel.com>; Deak, Imre <imre.deak at intel.com>;
> Murthy, Arun R <arun.r.murthy at intel.com>
> Subject: [PATCH 3/5] tests/intel/kms_link_training: extend test for eDP connector
> 
> Extend kms_link_training test for eDP connector.
> non-uhbr-sst subtest expected to and skip expected for rest of the subtest as of
> now.
> 
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Arun R Murthy <arun.r.murthy at intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
> ---
>  tests/intel/kms_link_training.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/kms_link_training.c b/tests/intel/kms_link_training.c index
> fb9b42608..3793fb84b 100644
> --- a/tests/intel/kms_link_training.c
> +++ b/tests/intel/kms_link_training.c
> @@ -260,14 +260,18 @@ static bool run_link_rate_test(data_t *data, bool mst,
> bool uhbr)  static bool test_link_rate(data_t *data, bool mst, bool uhbr)  {
>  	bool ran_any_output = false, is_mst = false;
> +	bool is_edp = false, is_dp = false;
>  	igt_output_t *tmp_output;
> 
>  	igt_skip_on_f(!is_intel_device(data->drm_fd),	
>  		      "Test supported only on Intel platforms.\n");
> 
>  	for_each_connected_output(&data->display, tmp_output) {
> -		if (tmp_output->config.connector->connector_type !=
> -		    DRM_MODE_CONNECTOR_DisplayPort) {
> +		is_edp = tmp_output->config.connector->connector_type ==
> +			 DRM_MODE_CONNECTOR_eDP;
> +		is_dp = tmp_output->config.connector->connector_type ==
> +			DRM_MODE_CONNECTOR_DisplayPort;
> +		if (!(is_edp || is_dp)) {
>  			igt_info("Skipping non-DisplayPort output %s\n",
>  					tmp_output->name);
Can we get the igt_info aligned with the change.

Also can we change something like below : -
static bool is_dp_or_edp(igt_output_t *output)
{
	uint32_t type = output->config.connector->connector_type;

	return type == DRM_MODE_CONNECTOR_DisplayPort ||
	       type == DRM_MODE_CONNECTOR_eDP;
}

Then in loop :-
for_each_connected_output(&data->display, tmp_output) {
	if (!is_dp_or_edp(tmp_output)) {
		igt_info("Skipping non-DP/eDP output %s\n", tmp_output->name);
		igt_info("----------------------------------------------------\n");
		continue;
	}
>  			igt_info("----------------------------------------------------
> \n");
> --
> 2.25.1