[PATCH i-g-t] tests/intel/kms_draw_crc: Skip formats not supported by the plane

Juha-Pekka Heikkilä juhapekka.heikkila at gmail.com
Wed Mar 5 14:40:07 UTC 2025


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On Mon, Mar 3, 2025 at 1:02 PM Ville Syrjala
<ville.syrjala at linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> The test only checks igt_display_has_format_mod() before
> deciding to test a specific format. But that doesn't
> mean the actual plane supports that format. Also check
> for that once we know which plane to use.
>
> Should turn the fp16 failures into skips on IVB because it
> doesn't have fp16 support on the primary plane.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  tests/intel/kms_draw_crc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/intel/kms_draw_crc.c b/tests/intel/kms_draw_crc.c
> index 9c350853cfd9..62c6c64be710 100644
> --- a/tests/intel/kms_draw_crc.c
> +++ b/tests/intel/kms_draw_crc.c
> @@ -158,6 +158,8 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format,
>
>         primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>
> +       igt_require(igt_plane_has_format_mod(primary, drm_format, modifier));
> +
>         igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay,
>                       drm_format, modifier, &fb);
>         igt_plane_set_fb(primary, &fb);
> --
> 2.45.3
>


More information about the igt-dev mailing list