[PATCH v3 i-g-t] runner: Parse results harder

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Mar 5 19:30:14 UTC 2025


Hi Krzysztof,
On 2025-03-04 at 09:41:20 +0000, Krzysztof Karas wrote:
> Hi Kamil,
> 
> >   Sometimes an error happens in kernel or in test that leaves
> > output files in corrupted or incorrect state. While runner or
> > resume will just move on to executing next test, when generating
> > results it could end up with no results.json
> > 
> >   Try processing outputs a little more persistently and use any
> > output file left there, even if only dmesg.txt. Also, when no
> > useful output files were present, instead of breaking out add
> > notrun.
> > 
> >   Inform about processing results for each test so a problem
> > could be spotted more easily.
> > 
> > v2: removed ')' from 'notrun\n)' (Kamil)
> >  using bool var, added more prints about errors (Ryszard)
> > v3: reused open_for_reading, removed bool var (Krzysztof)
> >  closing only positive fds[] in close_outputs(), checking
> >  file sizes also if all opens succeeded (Kamil)
> 
> Reviewed-by: Krzysztof Karas <krzysztof.karas at intel.com>
> 
> Best Regards,
> Krzysztof

Thank you for review, unfortunatly this didn't pass checks:
meson test -C build

see results in gitlab for v3:
https://patchwork.freedesktop.org/series/145520/#rev3

I sent v4 but after more checks and more code reading I wrote
new revision today and will send v5 soon, please check and
review.

Regards,
Kamil



More information about the igt-dev mailing list