[PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset before retraining

B, Jeevan jeevan.b at intel.com
Thu Mar 6 05:46:05 UTC 2025


LGTM.

Reviewed-by: Jeevan B <jeevan.b at intel.com>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Kunal
> Joshi
> Sent: Monday, March 3, 2025 1:39 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Joshi, Kunal1 <kunal1.joshi at intel.com>
> Subject: [PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset
> before retraining
> 
> Retraining can be done on enabled output.
> Fix test to do modeset before retraining.
> 
> v2: remove redundant modeset (Jeevan)
> 
> Fixes: 983ffca5ff96fd67c937691337f4488e28948aa7
> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
> ---
>  tests/intel/kms_dp_link_training.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_dp_link_training.c
> b/tests/intel/kms_dp_link_training.c
> index f00376614..e218c9839 100644
> --- a/tests/intel/kms_dp_link_training.c
> +++ b/tests/intel/kms_dp_link_training.c
> @@ -233,6 +233,7 @@ static bool run_link_rate_test(data_t *data, bool mst,
> bool uhbr)
> 
>  	igt_display_reset(&data->display);
>  	igt_reset_link_params(data->drm_fd, data->output);
> +	do_modeset(data, mst);
> 
>  	/* Retrain at default/driver parameters */
>  	igt_force_link_retrain(data->drm_fd, data->output,
> RETRAIN_COUNT); @@ -240,7 +241,6 @@ static bool
> run_link_rate_test(data_t *data, bool mst, bool uhbr)
>  						   igt_get_dp_pending_retrain,
>  						   1.0, 20.0), 0);
>  	assert_link_status_good(data, mst);
> -	do_modeset(data, mst);
> 
>  	/* FIXME : Driver may lie max link rate or max lane count */
>  	/* Read max_link_rate and max_lane_count */
> --
> 2.43.0



More information about the igt-dev mailing list