[PATCH i-g-t v1 1/3] tests/intel/kms_psr: Skip PSR test on joiner outputs

B, Jeevan jeevan.b at intel.com
Thu Mar 6 07:35:26 UTC 2025


> -----Original Message-----
> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> Sent: Thursday, March 6, 2025 9:10 AM
> To: igt-dev at lists.freedesktop.org
> Cc: B, Jeevan <jeevan.b at intel.com>; Naladala, Ramanaidu
> <ramanaidu.naladala at intel.com>; Hogander, Jouni
> <jouni.hogander at intel.com>; Joshi, Kunal1 <kunal1.joshi at intel.com>; Reddy
> Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> Subject: [PATCH i-g-t v1 1/3] tests/intel/kms_psr: Skip PSR test on joiner
> outputs
> 
> Skip the PSR test on joiner outputs as joiner cannot be used with PSR.
> 
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
>  tests/intel/kms_psr.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/tests/intel/kms_psr.c b/tests/intel/kms_psr.c index
> 124d7be18..c930e3872 100644
> --- a/tests/intel/kms_psr.c
> +++ b/tests/intel/kms_psr.c
> @@ -838,6 +838,11 @@ igt_main
>  			igt_subtest_with_dynamic_f("%s%sbasic",
> append_fbc_subtest[y],
>  						   append_subtest_name[z]) {
>  				for_each_connected_output(&data.display,
> output) {
> +					if (is_joiner_mode(data.drm_fd,
> output)) {
> +						igt_info("%s supports joiner
> mode, can't test PSR + joiner\n",
> +
> 	igt_output_name(output));
> +						continue;
> +					}
This checks for mode present and continues, I think its better to use igt_is_joiner_enabled_for_pipe for the particular pipe 
Or even load non joiner mode to run the test. 

The same goes for other patches in the same series. 

Thanks 
Jeevan B 
>  					if (!psr_sink_support(data.drm_fd,
> data.debugfs_fd,
> 
> data.op_psr_mode, output))
>  						continue;
> @@ -855,6 +860,11 @@ igt_main
>  			igt_subtest_with_dynamic_f("%s%sno-drrs",
> append_fbc_subtest[y],
>  						   append_subtest_name[z]) {
>  				for_each_connected_output(&data.display,
> output) {
> +					if (is_joiner_mode(data.drm_fd,
> output)) {
> +						igt_info("%s supports joiner
> mode, can't test PSR + joiner\n",
> +
> igt_output_name(output));
> +						continue;
> +					}
>  					if (!psr_sink_support(data.drm_fd,
> data.debugfs_fd,
> 
> data.op_psr_mode, output))
>  						continue;
> @@ -878,6 +888,11 @@ igt_main
> 
> 	igt_skip_on(is_xe_device(data.drm_fd) &&
>  						    (op == MMAP_CPU || op ==
> MMAP_GTT));
> 
> 	for_each_connected_output(&data.display, output) {
> +						if
> (is_joiner_mode(data.drm_fd, output)) {
> +							igt_info("%s supports
> joiner mode, can't test PSR + joiner\n",
> +
> igt_output_name(output));
> +							continue;
> +						}
>  						if
> (!psr_sink_support(data.drm_fd, data.debugfs_fd,
> 
> data.op_psr_mode, output))
>  							continue;
> @@ -902,6 +917,11 @@ igt_main
> 
> 	igt_skip_on(is_xe_device(data.drm_fd) &&
>  						    (op == MMAP_CPU || op ==
> MMAP_GTT));
> 
> 	for_each_connected_output(&data.display, output) {
> +						if
> (is_joiner_mode(data.drm_fd, output)) {
> +							igt_info("%s supports
> joiner mode, can't test PSR + joiner\n",
> +
> igt_output_name(output));
> +							continue;
> +						}
>  						if
> (!psr_sink_support(data.drm_fd, data.debugfs_fd,
> 
> data.op_psr_mode, output))
>  							continue;
> @@ -924,6 +944,11 @@ igt_main
> 
> 	igt_skip_on(is_xe_device(data.drm_fd) &&
>  						    (op == MMAP_CPU || op ==
> MMAP_GTT));
> 
> 	for_each_connected_output(&data.display, output) {
> +						if
> (is_joiner_mode(data.drm_fd, output)) {
> +							igt_info("%s supports
> joiner mode, can't test PSR + joiner\n",
> +
> igt_output_name(output));
> +							continue;
> +						}
>  						if
> (!psr_sink_support(data.drm_fd, data.debugfs_fd,
> 
> data.op_psr_mode, output))
>  							continue;
> @@ -944,6 +969,11 @@ igt_main
>  			igt_subtest_with_dynamic_f("%s%sdpms",
> append_fbc_subtest[y],
>  						   append_subtest_name[z]) {
>  				for_each_connected_output(&data.display,
> output) {
> +					if (is_joiner_mode(data.drm_fd,
> output)) {
> +						igt_info("%s supports joiner
> mode, can't test PSR + joiner\n",
> +
> igt_output_name(output));
> +						continue;
> +					}
>  					if (!psr_sink_support(data.drm_fd,
> data.debugfs_fd,
> 
> data.op_psr_mode, output))
>  						continue;
> @@ -966,6 +996,11 @@ igt_main
>  			igt_subtest_with_dynamic_f("%s%ssuspend",
> append_fbc_subtest[y],
>  						   append_subtest_name[z]) {
>  				for_each_connected_output(&data.display,
> output) {
> +					if (is_joiner_mode(data.drm_fd,
> output)) {
> +						igt_info("%s supports joiner
> mode, can't test PSR + joiner\n",
> +
> igt_output_name(output));
> +						continue;
> +					}
>  					if (!psr_sink_support(data.drm_fd,
> data.debugfs_fd,
> 
> data.op_psr_mode, output))
>  						continue;
> --
> 2.34.1



More information about the igt-dev mailing list