[PATCH i-g-t v1] tests/intel/kms_fbc_dirty_rect: fix the log level in fbc enabled check

B, Jeevan jeevan.b at intel.com
Thu Mar 6 07:55:16 UTC 2025


LGTM.

Reviewed-by: Jeevan B <jeevan.b at intel.com>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Vinod
> Govindapillai
> Sent: Wednesday, March 5, 2025 4:02 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Govindapillai, Vinod <vinod.govindapillai at intel.com>; Reddy Guddati,
> Santhosh <santhosh.reddy.guddati at intel.com>; Saarinen, Jani
> <jani.saarinen at intel.com>
> Subject: [PATCH i-g-t v1] tests/intel/kms_fbc_dirty_rect: fix the log level in fbc
> enabled check
> 
> Even if FBC is enabled and test is successfull, using warn level to print the info
> will make the CI treat this as a failure. In case FBC is not enabled, the assert will
> be triggered and print the error case.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai at intel.com>
> ---
>  tests/intel/kms_fbc_dirty_rect.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_fbc_dirty_rect.c b/tests/intel/kms_fbc_dirty_rect.c
> index 1e3fc1d33..ea7a73124 100644
> --- a/tests/intel/kms_fbc_dirty_rect.c
> +++ b/tests/intel/kms_fbc_dirty_rect.c
> @@ -130,7 +130,7 @@ set_fb_and_collect_crc(data_t *data, igt_plane_t
> *plane, struct igt_fb *fb,
>  	igt_pipe_crc_get_current(data->drm_fd, data->pipe_crc, crc);
>  	igt_pipe_crc_stop(data->pipe_crc);
>  	igt_assert_f(intel_fbc_is_enabled(data->drm_fd, data->pipe,
> -					  IGT_LOG_WARN),
> +					  IGT_LOG_INFO),
>  					  "FBC is not enabled\n");
>  }
> 
> --
> 2.43.0



More information about the igt-dev mailing list