[PATCH v2 i-g-t 0/2] tests/xe_drm_fdinfo: Check prerequisites for utilization tests

Marcin Bernatowicz marcin.bernatowicz at linux.intel.com
Thu Mar 6 20:01:16 UTC 2025


This patch series ensures that utilization tests correctly check for
required utilization data before execution.

The first patch initially introduced an igt_subtest_group with a fixture
to verify utilization data availability. However, as pointed out by Kamil,
the fixture would still execute even if no test from the group was
selected, leading to potential log messages about unmet requirements when
running unrelated tests.

To address this, v2 introduces a helper function,
require_engine_utilization_data(), which is explicitly
called in each utilization-related subtest.

The second patch remains unchanged and replaces igt_require with
igt_assert in basic_engine_utilization, ensuring the test fails
explicitly when utilization data is missing.

V2:
- Dropped igt_subtest_group, as its fixture executed unconditionally.
- Introduced require_engine_utilization_data() helper to check
  prerequisites in each subtest.
- Extended the requirement checks for the presence of engine utilization
  cycles.

Cc: Jakub Kolakowski <jakub1.kolakowski at intel.com>
Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Cc: Lukasz Laguna <lukasz.laguna at intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Marcin Bernatowicz (2):
  tests/intel/xe_drm_fdinfo: Check prerequisites for utilization
    subtests
  tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no
    utilization data

 tests/intel/xe_drm_fdinfo.c | 56 +++++++++++++++++++++++++++++--------
 1 file changed, 44 insertions(+), 12 deletions(-)

-- 
2.31.1



More information about the igt-dev mailing list