[PATCH v2 i-g-t 2/2] tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no utilization data

[Kolakowski, Jakub1]

Hi Marcin,

LGTM,
Reviewed-by: Jakub Kolakowski <jakub1.kolakowski at intel.com>

-----Original Message-----
From: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com> 
Sent: Thursday, March 6, 2025 9:01 PM
To: igt-dev at lists.freedesktop.org
Cc: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>; Kolakowski, Jakub1 <jakub1.kolakowski at intel.com>; De Marchi, Lucas <lucas.demarchi at intel.com>; Laguna, Lukasz <lukasz.laguna at intel.com>; Nerlige Ramappa, Umesh <umesh.nerlige.ramappa at intel.com>
Subject: [PATCH v2 i-g-t 2/2] tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no utilization data

Replace igt_require with igt_assert to enforce that num_engines is nonzero rather than skipping the test. This ensures the test fails explicitly if engine utilization data is missing.

Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski at intel.com>
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Cc: Lukasz Laguna <lukasz.laguna at intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
---
 tests/intel/xe_drm_fdinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/xe_drm_fdinfo.c b/tests/intel/xe_drm_fdinfo.c index f166b73d6..9a8811b4c 100644
--- a/tests/intel/xe_drm_fdinfo.c
+++ b/tests/intel/xe_drm_fdinfo.c
@@ -377,7 +377,7 @@ static void basic_engine_utilization(int xe)
 				   ARRAY_SIZE(engine_map), NULL, 0);
 	igt_assert_f(ret != 0, "failed with err:%d\n", errno);
 	igt_assert(!strcmp(info.driver, "xe"));
-	igt_require(info.num_engines);
+	igt_assert(info.num_engines);
 }
 
 static void
--
2.31.1