[PATCH i-g-t 02/11] lib/intel_compute: Use common constant for dynamic state size

[Thomas Hellström]

On Tue, 2025-03-11 at 16:21 +0100, Francois Dugast wrote:
> Reduce magic values in the code, homogenize the size which has no
> reason to be different among pipelines, define this value close to
> the addresses to make it easier to spot potential overlaps in the
> future.
> 
> Signed-off-by: Francois Dugast <francois.dugast at intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>

> ---
>  lib/intel_compute.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 7d3380186..b4b022ae7 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -29,6 +29,7 @@
>  #define SIZE_BUFFER_INPUT		MAX(sizeof(float) *
> SIZE_DATA, 0x10000)
>  #define SIZE_BUFFER_OUTPUT		MAX(sizeof(float) *
> SIZE_DATA, 0x10000)
>  #define SIZE_SURFACE_STATE		0x10000
> +#define SIZE_DYNAMIC_STATE		0x100000
>  
>  #define ADDR_SYNC			0x010000ULL
>  #define ADDR_SYNC2			0x020000ULL
> @@ -691,7 +692,7 @@ static void compute_exec(int fd, const unsigned
> char *kernel,
>  		{ .addr = ADDR_INDIRECT_OBJECT_BASE + OFFSET_KERNEL,
>  		  .name = "kernel" },
>  		{ .addr = ADDR_DYNAMIC_STATE_BASE,
> -		  .size =  0x1000,
> +		  .size = SIZE_DYNAMIC_STATE,
>  		  .name = "dynamic state base" },
>  		{ .addr = ADDR_SURFACE_STATE_BASE,
>  		  .size = SIZE_SURFACE_STATE,
> @@ -976,7 +977,7 @@ static void xehp_compute_exec(int fd, const
> unsigned char *kernel,
>  		{ .addr = ADDR_INSTRUCTION_STATE_BASE +
> OFFSET_KERNEL,
>  		  .name = "instr state base"},
>  		{ .addr = ADDR_DYNAMIC_STATE_BASE,
> -		  .size = 0x100000,
> +		  .size = SIZE_DYNAMIC_STATE,
>  		  .name = "dynamic state base"},
>  		{ .addr = ADDR_SURFACE_STATE_BASE,
>  		  .size = SIZE_SURFACE_STATE,
> @@ -1551,7 +1552,7 @@ static void xelpg_compute_exec(int fd, const
> unsigned char *kernel,
>  		{ .addr = ADDR_INSTRUCTION_STATE_BASE +
> OFFSET_KERNEL,
>  		  .name = "instr state base"},
>  		{ .addr = ADDR_DYNAMIC_STATE_BASE,
> -		  .size = 0x100000,
> +		  .size = SIZE_DYNAMIC_STATE,
>  		  .name = "dynamic state base"},
>  		{ .addr = ADDR_SURFACE_STATE_BASE,
>  		  .size = SIZE_SURFACE_STATE,
> @@ -1641,7 +1642,7 @@ static void xe2lpg_compute_exec(int fd, const
> unsigned char *kernel,
>  		{ .addr = ADDR_INSTRUCTION_STATE_BASE +
> OFFSET_KERNEL,
>  		  .name = "instr state base"},
>  		{ .addr = ADDR_DYNAMIC_STATE_BASE,
> -		  .size = 0x100000,
> +		  .size = SIZE_DYNAMIC_STATE,
>  		  .name = "dynamic state base"},
>  		{ .addr = ADDR_SURFACE_STATE_BASE,
>  		  .size = SIZE_SURFACE_STATE,
> @@ -1892,7 +1893,7 @@ static void xe2lpg_compute_preempt_exec(int fd,
> const unsigned char *long_kernel
>  		{ .addr = ADDR_INSTRUCTION_STATE_BASE +
> OFFSET_KERNEL,
>  		  .name = "instr state base"},
>  		{ .addr = ADDR_DYNAMIC_STATE_BASE,
> -		  .size = 0x100000,
> +		  .size = SIZE_DYNAMIC_STATE,
>  		  .name = "dynamic state base"},
>  		{ .addr = ADDR_SURFACE_STATE_BASE,
>  		  .size = SIZE_SURFACE_STATE,